Re: [PATCH] arm64: dts: qcom: Add PMIC thermal support for Agatti QRB2210-RB1 platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Missing `polling-delay` property in thermal zones prevents them from being polled, rendering thermal mitigation non-functional.
- [Low] The patch references a device tree label `pm4125_adc` that appears undefined, which will cause a fatal `dtc` compilation error.
--

--- Patch [1]: [PATCH] arm64: dts: qcom: Add PMIC thermal support for Agatti QRB2210-RB1 platform ---
commit 01dca3a5fb92132d1ae40d936842a155e5f13716
Author: Raj Aryan <raj.aryan@oss.qualcomm.com>

arm64: dts: qcom: Add PMIC thermal support for Agatti QRB2210-RB1 platform
    
Add ADC channels for msm, quiet and xo thermistors along with
their ADC thermal bridge nodes and thermal zones for PMIC
thermal mitigation.

> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts

[ ... ]

> @@ -33,6 +34,68 @@ clk40m: can-clk {
>  		};
>  	};
>  
> +	msm_therm_bridge: msm-therm-bridge {
> +		compatible = "generic-adc-thermal";
> +		io-channels = <&pm4125_adc ADC5_AMUX_THM3_100K_PU>;

[Severity: Low]
Is the pm4125_adc label defined in any of the included files?

If not, will this cause a dtc compilation error due to an undefined phandle?

> +		io-channel-names = "sensor-channel";
> +		#thermal-sensor-cells = <0>;
> +	};

[ ... ]

> +	thermal-zones {
> +		sys-1-thermal {
> +			polling-delay-passive = <2000>;

[Severity: High]
Does this thermal zone also need a polling-delay property?

If polling-delay is omitted, it defaults to 0. Since there are only hot trips
defined, the zone will never enter passive cooling mode and therefore might
never be polled by the thermal core, rendering mitigation non-functional.

This missing property appears in sys-1-thermal, sys-2-thermal, and
sys-3-thermal.

> +			thermal-sensors = <&msm_therm_bridge>;

[ ... ]

> @@ -333,6 +396,34 @@ vreg_l7p: ldo7 {
>  	};
>  };
>  
> +&pm4125_adc {

[Severity: Low]
Similar to the io-channels property above, will extending this pm4125_adc
label cause a build failure if it isn't defined?

> +	status = "okay";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-pm4125-adc-thermal-v1-1-3b67ef2eccb2@oss.qualcomm.com?part=1