Re: [PATCH] dt-bindings: hwmon: ti,tmp401: add vcc-supply and #thermal-sensor-cells

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message contains a major factual error: it justifies adding the `vcc-supply` property by claiming it is fetched by `lm90_probe()` in `drivers/hwmon/lm90.c`, but the `ti,tmp401` and `ti,tmp411` devices are actually backed by `drivers/hwmon/tmp401.c`, which completely lacks regulator support.
--

--- Patch [1]: [PATCH] dt-bindings: hwmon: ti,tmp401: add vcc-supply and #thermal-sensor-cells ---
commit bb8183d96c519f5d3050a2f78596d89eca815884
Author: Vincent Jardin <vjardin@free.fr>

dt-bindings: hwmon: ti,tmp401: add vcc-supply and #thermal-sensor-cells

This commit updates the ti,tmp401 device tree binding to include the
vcc-supply and #thermal-sensor-cells properties. It aims to fix
dtbs_check warnings for boards that describe these features.

> vcc-supply is fetched in lm90_probe():
>
>   drivers/hwmon/lm90.c:2777
>         err = devm_regulator_get_enable(dev, "vcc");
>
> so a board with the sensor behind a switched rail has no other way to
> describe it, and omitting it means the chip is probed with its supply
> possibly off.

[Severity: Medium]
Is this justification accurate for the ti,tmp401 binding?

The ti,tmp401 and ti,tmp411 devices appear to be backed by the driver
in drivers/hwmon/tmp401.c, rather than lm90.c.

Looking at tmp401_probe(), it currently lacks regulator support and does
not call devm_regulator_get_enable(). Does this mean boards using the
tmp401 sensor with a switched rail will still fail to power up the chip
since the driver ignores the property?

> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
> index 0e8ddf0ad7890..69f77aec01a33 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
[ ... ]
> @@ -50,6 +50,11 @@ properties:
>      minimum: 0
>      maximum: 15
>  
> +  vcc-supply: true

[Severity: Medium]
While adding this property correctly describes the hardware and silences the
dtbs_check warnings, should the drivers/hwmon/tmp401.c driver also be
updated in a companion patch so it actually parses and enables this supply?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-for-upstream-dt-tmp401-vcc-tsc-v1-1-ecb5ef7898bd@free.fr?part=1