From: sashiko-bot@kernel.org
To: "Rudraksha Gupta" <guptarud@gmail.com>
Cc: linux-clk@vger.kernel.org, lee@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org,
mfd@lists.linux.dev, robh@kernel.org
Subject: Re: [PATCH v2 1/2] arm64: dts: rockchip: Enable the EG25-G modem on the Pinephone Pro
Date: Tue, 25 Aug 2026 05:24:22 +0000 [thread overview]
Message-ID: <20260825052423.5B5011F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260824-ppp_connectivity-v2-1-a4b0e11cd62c@gmail.com>
> From: Martijn Braam <martijn@brixit.nl>
>
> The Quectel EG25-G modem is soldered to the board. It sits on the USB 2.0
> host controller behind u2phy1, with uart3 as its AT command port, and
> draws from two switched rails: vcc_4g_5v off the RK818 boost, and vcc_4g
> off vcc_sys.
>
> Neither rail supplies anything but the modem, which has to stay powered
> for the board to work as a phone, so both are always-on.
>
> The modem itself has no binding and no in-kernel driver, so it is not
> described here; its control lines are driven from userspace.
>
> Based on work by Martijn Braam, Kamil Trzciński, Ondrej Jirman and Dang
> Huynh.
>
> Signed-off-by: Martijn Braam <martijn@brixit.nl>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-ppp_connectivity-v2-0-a4b0e11cd62c@gmail.com?part=1
next prev parent reply other threads:[~2026-08-25 5:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 5:18 [PATCH v2 0/2] Pinephone Pro Connectivity: Adding Modem, Bluetooth, and Wi-Fi Rudraksha Gupta via B4 Relay
2026-08-25 5:18 ` [PATCH v2 1/2] arm64: dts: rockchip: Enable the EG25-G modem on the Pinephone Pro Rudraksha Gupta via B4 Relay
2026-08-25 5:24 ` sashiko-bot [this message]
2026-08-25 5:18 ` [PATCH v2 2/2] clk: rk808: Select the clock function of CLK32KOUT2 on the RK818 Rudraksha Gupta via B4 Relay
2026-08-25 5:22 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825052423.5B5011F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guptarud@gmail.com \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox