Re: [PATCH v2 1/3] dt-bindings: rtc: add ricoh,r2223x binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#clock-cells` property is omitted from the `required` list despite the device functioning as a clock provider.
--

--- Patch [1]: [PATCH v2 1/3] dt-bindings: rtc: add ricoh,r2223x binding ---
commit c9a8726516af9b3ebff5835956246051050d1e80
Author: Heiko Schocher <hs@nabladev.com>

dt-bindings: rtc: add ricoh,r2223x binding

This commit adds a new device tree binding for the Ricoh R2223x I2C RTC.
The device drives a clock output and features an eco mode to lower current
consumption from the backup supply.

> diff --git a/Documentation/devicetree/bindings/rtc/ricoh,r2223x.yaml b/Documentation/devicetree/bindings/rtc/ricoh,r2223x.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ricoh,r2223x.yaml
[ ... ]
> +  start-year: true
> +
> +required:
> +  - compatible
> +  - reg

[Severity: Medium]
Since this device functions as a clock provider and defines #clock-cells,
should #clock-cells be included in the required list?

Omitting it allows incomplete device tree nodes to pass schema validation
but fail at runtime when dependent subsystems attempt to use the clock
functionality.

> +
> +additionalProperties: false
> +
> +examples:
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825071927.4090460-1-hs@nabladev.com?part=1