From: sashiko-bot@kernel.org
To: "Tommaso Merciai" <tommaso.merciai.xr@bp.renesas.com>
Cc: robh@kernel.org, conor+dt@kernel.org,
wsa+renesas@sang-engineering.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: renesas: r9a08g046: Add USB2.0 function device nodes
Date: Tue, 25 Aug 2026 13:24:40 +0000 [thread overview]
Message-ID: <20260825132440.E6D261F000E9@smtp.kernel.org> (raw)
In-Reply-To: <962c65901519b066b201f5f9bf15047f9aa45ffc.1787663426.git.tommaso.merciai.xr@bp.renesas.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added compatible string `renesas,usbhs-r9a08g046` is not documented in the device tree bindings schema.
--
--- Patch [2]: [PATCH v2 2/4] arm64: dts: renesas: r9a08g046: Add USB2.0 function device nodes ---
commit aca75e8826ebba62b782808787871b01e25c5783
Author: Biju Das <biju.das.jz@bp.renesas.com>
arm64: dts: renesas: r9a08g046: Add USB2.0 function device nodes
Add USB2.0 function device nodes to the RZ/G3L (r9a08g046) SoC DTSI.
> diff --git a/arch/arm64/boot/dts/renesas/r9a08g046.dtsi b/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> index 2d8c8fd8a01cd..7cf29aed52110 100644
> --- a/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> @@ -1105,6 +1105,44 @@ usb2_phy1: usb-phy@11e90200 {
> status = "disabled";
> };
>
> + hsusb0: usb@11e30000 {
> + compatible = "renesas,usbhs-r9a08g046",
> + "renesas,rzg2l-usbhs";
[Severity: Low]
This isn't a bug, but it appears the newly added compatible string
renesas,usbhs-r9a08g046 is not documented in the device tree bindings
schema. Will this cause warnings during make dtbs_check?
[ ... ]
> + hsusb1: usb@11eb0000 {
> + compatible = "renesas,usbhs-r9a08g046",
> + "renesas,rzg2l-usbhs";
[Severity: Low]
This isn't a bug, but the same undocumented compatible string is used here
for the hsusb1 node. Should this string be added to
Documentation/devicetree/bindings/usb/renesas,usbhs.yaml?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1787663426.git.tommaso.merciai.xr@bp.renesas.com?part=2
next prev parent reply other threads:[~2026-08-25 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 13:15 [PATCH v2 0/4] Add USB2.0 support for RZ/G3E Tommaso Merciai
2026-08-25 13:15 ` [PATCH v2 1/4] arm64: dts: renesas: r9a08g046: Add USB2.0 host/phy device nodes Tommaso Merciai
2026-08-25 13:15 ` [PATCH v2 2/4] arm64: dts: renesas: r9a08g046: Add USB2.0 function " Tommaso Merciai
2026-08-25 13:24 ` sashiko-bot [this message]
2026-08-25 13:15 ` [PATCH v2 3/4] arm64: dts: renesas: r9a09g047: Add USB2.0 support Tommaso Merciai
2026-08-25 13:28 ` sashiko-bot
2026-08-25 13:15 ` [PATCH v2 4/4] arm64: dts: renesas: r9a09g047e57-smarc: Enable " Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825132440.E6D261F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tommaso.merciai.xr@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox