From: sashiko-bot@kernel.org
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org,
wsa+renesas@sang-engineering.com
Subject: Re: [PATCH] dt-bindings: i2c: renesas,rcar-i2c: allow 6 DMA channels
Date: Tue, 25 Aug 2026 20:42:03 +0000 [thread overview]
Message-ID: <20260825204204.0E52B1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260825203251.2118-2-wsa+renesas@sang-engineering.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Globally increasing maxItems for 'dmas' and 'dma-names' to 6 allows invalid device trees for older hardware generations (Gen3/Gen4) to silently pass schema validation.
--
commit 25b051c331e08902e326728248cc79cc367f0460
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
dt-bindings: i2c: renesas,rcar-i2c: allow 6 DMA channels
This commit increases the maximum number of DMA channels for the Renesas
R-Car I2C controller from 4 to 6 to accommodate Gen5 hardware.
> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml b/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
> index c4ace5585e1e2..bfe55e20f1251 100644
> --- a/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
> @@ -77,14 +77,14 @@ properties:
>
> dmas:
> minItems: 2
> - maxItems: 4
> + maxItems: 6
[Severity: Medium]
Doesn't globally increasing maxItems to 6 allow invalid device trees for older
hardware generations (Gen3/Gen4) to silently pass schema validation?
According to the device tree subsystem guidelines, stricter constraints for
older generations must be preserved using if-then conditional blocks when new
hardware variants relax limits. Otherwise, dt_binding_check will incorrectly
accept up to 6 DMA channels for older hardware that only supports 4.
> description:
> Must contain a list of pairs of references to DMA specifiers, one for
> transmission, and one for reception.
>
> dma-names:
> minItems: 2
> - maxItems: 4
> + maxItems: 6
[Severity: Medium]
Does this also need a conditional block to protect earlier hardware?
Similar to the dmas property above, globally relaxing the maxItems limit for
dma-names without adding an if-then conditional constraint removes the
4-channel constraint for Gen3/Gen4 hardware.
> items:
> enum:
> - tx
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260825203251.2118-2-wsa+renesas@sang-engineering.com?part=1
next prev parent reply other threads:[~2026-08-25 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 20:31 [PATCH] dt-bindings: i2c: renesas,rcar-i2c: allow 6 DMA channels Wolfram Sang
2026-08-25 20:42 ` sashiko-bot [this message]
2026-08-26 6:18 ` Wolfram Sang
2026-08-26 8:07 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825204204.0E52B1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox