Re: [PATCH v4 1/2] dt-bindings: backlight: Add Orient Chip OCP8178

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Using `additionalProperties: false` with an `allOf` `$ref` breaks property inheritance.
--

commit 76f37f9a56bf914fefbc5653351c8e4714ee18e8
Author: Wim de With <wf@dewith.io>

dt-bindings: backlight: Add Orient Chip OCP8178

Add device tree bindings for the Orient Chip OCP8178 LED backlight
driver.

> diff --git a/Documentation/devicetree/bindings/leds/backlight/ocs,ocp8178.yaml b/Documentation/devicetree/bindings/leds/backlight/ocs,ocp8178.yaml
> new file mode 100644
> index 0000000000000..1cd95aac0d168
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/ocs,ocp8178.yaml

[ ... ]

> +allOf:
> +  - $ref: common.yaml#
> +
> +properties:
> +  compatible:
> +    const: ocs,ocp8178

[ ... ]

> +required:
> +  - compatible
> +  - ctrl-gpios
> +
> +additionalProperties: false

[Severity: Medium]
Since this schema includes an allOf reference to common.yaml#, does using
additionalProperties: false break property inheritance? This will reject
standard backlight properties not explicitly listed in the local schema
during device tree validation.

Should this use unevaluatedProperties: false instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-ocp8178-backlight-v4-0-47d7acce882e@dewith.io?part=1