Re: [PATCH v5 09/10] dtc: dt-check-style: Add warning for redundant white-spaces

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The patch adds an undocumented check for redundant whitespace after ':', creating a meaningful commit message and code mismatch.
- [Low] The newly added `check_redundant_whitespace_strict` function fails to inspect continuation lines.
--

commit 57a0fd97078063900e6ed8376ac59fb6edea822d
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Add warning for redundant white-spaces

Show warnings of too many spaces around '=', before '{' and ';'
characters, or using tabs for these.  Both in-tree DTS and DT bindings
have many warnings for the first case (too mant spaces around '='), thus
keep this one only for 'strict' mode.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index da7edd5ea079d..a60891d76137f 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -349,6 +349,42 @@ def check_trailing_whitespace(ctx):
>              yield (dl.lineno, 'trailing whitespace')
>  
>  
> +def _check_redundant_whitespace(dl):
> +    if dl.linetype in (LineType.COMMENT, LineType.COMMENT_BODY,
> +                        LineType.COMMENT_END, LineType.COMMENT_START,
> +                        LineType.PREPROCESSOR):
> +        return
> +    if re.search(r'(\s\s+|\t)\{', dl.code):
> +        yield (dl.lineno, 'extra whitespace before {')
> +    if re.search(r':(\s\s+|\t)', dl.code):
> +        yield (dl.lineno, 'extra whitespace after :')

[Severity: Medium]
The commit message states: "Show warnings of too many spaces around '=',
before '{' and ';' characters, or using tabs for these."

Does this undocumented check for redundant whitespace after ':' in
_check_redundant_whitespace() create a meaningful mismatch between the
commit message and the code?

> +    if re.search(r'\s+;', dl.code):
> +        yield (dl.lineno, 'extra whitespace before ;')
> +
> +
> +def check_redundant_whitespace(ctx):
> +    """No whitespace between brackets or other code elements.
> +    See also check_value_whitespace() for more checks."""
> +    for dl in ctx.lines:
> +        yield from _check_redundant_whitespace(dl)
> +        for cont in dl.continuations:
> +            yield from _check_redundant_whitespace(cont)
> +
> +
> +def check_redundant_whitespace_strict(ctx):
> +    """No whitespace between brackets or other code elements.
> +    See also check_value_whitespace() for more checks."""
> +    for dl in ctx.lines:
> +        if dl.linetype in (LineType.COMMENT, LineType.COMMENT_BODY,
> +                           LineType.COMMENT_END, LineType.COMMENT_START,
> +                           LineType.PREPROCESSOR):
> +            continue
> +        if re.search(r'(\s\s+|\t)=', dl.code):
> +            yield (dl.lineno, 'extra whitespace before =')
> +        if re.search(r'=(\s\s+|\t)', dl.code):
> +            yield (dl.lineno, 'extra whitespace after =')

[Severity: Low]
This function fails to inspect continuation lines in
check_redundant_whitespace_strict().

Does the omission of a nested for cont in dl.continuations: block cause
the script to silently miss checking for redundant whitespace around '=' if
the '=' character happens to be placed on a multi-line continuation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-n-dts-style-checker-continued-v5-0-fdd16ca6e771@oss.qualcomm.com?part=9