Re: [PATCH v6 03/10] dtc: dt-check-style: Fix alignment of values in continued property lines

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect continuation alignment target column calculation when block comments precede the first '<' or '"'.
--

commit 88a2bc80735f633fd569467a745101b91a3872d0
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Fix alignment of values in continued property lines

This patch updates dt-check-style to check alignment of continued property
values to inner values if they are part of a previous phandle. It ignores
comments and trailing whitespace when determining the continuation alignment
target column.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 22e1ceac7f8b7..eb5045f0ad9e4 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style

[ ... ]

> @@ -938,17 +939,26 @@ def check_continuation_alignment(ctx):
>          eq = dl.raw.find('=')
>          if eq < 0:
>              continue
> -        # First '<' or '"' after '='
> -        rest = dl.raw[eq + 1:]
> -        m = re.search(r'[<"]', rest)
> +        # First '<' or '"' after '=', but ignore comments and strip trailing
> +        # whitespace (e.g. remaining after removing the comment)
> +        rest = _strip_strings_and_comments(dl.raw[eq + 1:]).rstrip()
> +        m = re.search(r'\s*([<"])', rest)
>          if not m:
>              continue
> -        target_col = _display_col(dl.raw[:eq + 1 + m.start()])
> +        dl_value_complete = rest.endswith('",') or rest.endswith('>,')
> +        target_col = _display_col(_strip_strings_and_comments(dl.raw[:eq + 1 + m.start(1)]))

[Severity: Medium]
Will this calculate an incorrect target column if a block comment precedes
the first '<' or '"'?

In check_continuation_alignment(), m.start(1) provides an index derived
from rest, which has had comments stripped via _strip_strings_and_comments(). 
However, it is then used to slice dl.raw, which is the original unstripped 
string. 

If a device tree property assignment contains a block comment between the 
'=' sign and the first '<' or '"' (for example: reg = /* comment */ <...>), 
the m.start(1) index will be too small. This will prematurely truncate 
dl.raw during the slice (often in the middle of the comment), causing 
_display_col() to evaluate a much smaller target column than expected. 

This can lead to false positive warnings for correctly aligned property
continuations.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-n-dts-style-checker-continued-v6-0-f270b1e81f8e@oss.qualcomm.com?part=3