Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On Thu, Aug 20, 2026 at 10:55:23AM +0300, Alexander Shiyan wrote:
> Add devicetree binding for the onsemi AR0234 CMOS image sensor.
> 
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
>  .../bindings/media/i2c/onnn,ar0234.yaml       | 121 ++++++++++++++++++
>  1 file changed, 121 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
>

Unanswered Sashiko comments.

> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> new file mode 100644
> index 000000000000..ee321acf22b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> @@ -0,0 +1,121 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/onnn,ar0234.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ON Semiconductor AR0234 1/2.6-inch CMOS Digital Image Sensor
> +
> +maintainers:
> +  - Alexander Shiyan <eagle.alexander923@gmail.com>
> +
> +description:
> +  The AR0234 is a 1/2.6-inch CMOS digital image sensor with a pixel
> +  array of 1940x1220 pixels, capable of 1920x1200 resolution at up
> +  to 120 fps. It supports MIPI CSI-2 output with 2 or 4 data lanes,
> +  color raw Bayer (8/10-bit) or monochrome output.
> +
> +allOf:
> +- $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - onnn,ar0234cssc
> +      - onnn,ar0234cssm
> +      - onnn,ar0234cs
> +    description:
> +      The AR0234 sensor exists in two different models, a colour variant
> +      (AR0234CSSC) and a monochrome variant (AR0234CSSM). The device exposes
> +      the model through registers, allowing for auto-detection with a common
> +      "onnn,ar0234cs" compatible string.

So all devices are compatible? Then why compatibility is not expressed?
What are the actual programming differences between sc, sm and "none"
variants?

...


> +  vddio-supply:
> +    description: I/O (1.8V-2.8V) supply regulator
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    description: CSI-2 transmitter port
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            oneOf:
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +                  - const: 3
> +                  - const: 4
> +
> +          link-frequencies: true

Drop

Best regards,
Krzysztof