Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kristian Brox <isyourbrainfoss@proton.me>
Cc: Luca Weiss <luca.weiss@fairphone.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	oe-linux-nfc@lists.linux.dev, netdev@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: net: nfc: add st,st21nfcd
Date: Thu, 27 Aug 2026 12:28:01 +0200	[thread overview]
Message-ID: <20260827-slick-mahogany-ara-bdbd1c@quoll> (raw)
In-Reply-To: <20260820-fp5-st21nfcd-v3-v3-1-5ee0a7f44d04@proton.me>

On Thu, Aug 20, 2026 at 08:56:07PM +0000, Kristian Brox wrote:
>    reset-gpios:
>      description: Output GPIO pin used for resetting the controller
> @@ -36,6 +37,15 @@ properties:
>        Specifies that the uicc swp signal can be physically connected to the
>        controller
>  
> +  clocks:
> +    maxItems: 1
> +    description:
> +      External reference clock connected to SYS_CLK.
> +
> +  vdd-io-supply:
> +    description:
> +      Digital I/O supply (VPS_IO).
> +
>  required:
>    - compatible
>    - interrupts
> @@ -49,6 +59,7 @@ if:
>          enum:
>            - st,st21nfcb-i2c
>            - st,st21nfcc-i2c
> +          - st,st21nfcd

This is not true. Please open datasheet - it clearly says SPI interface.

>  then:
>    properties:
>      spi-max-frequency: false
> @@ -81,6 +92,26 @@ examples:
>          };
>      };
>  
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {

Both clocks and vdd-io supply are valid for other devices, so just add
them there and drop the new example.

Best regards,
Krzysztof


  reply	other threads:[~2026-08-27 10:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 20:56 [PATCH v3 0/3] nfc: st-nci: Fairphone 5 NFC bring-up (ST21NFCD) Kristian Brox
2026-08-20 20:56 ` [PATCH v3 1/3] dt-bindings: net: nfc: add st,st21nfcd Kristian Brox
2026-08-27 10:28   ` Krzysztof Kozlowski [this message]
2026-08-20 20:56 ` [PATCH v3 2/3] nfc: st-nci: add raw NCI path for ST21NFCD Kristian Brox
2026-08-21 20:56   ` sashiko-bot
2026-08-23  8:32   ` David Heidelberg
2026-08-27 10:18   ` Krzysztof Kozlowski
2026-08-20 20:56 ` [PATCH v3 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: add ST21NFCD NFC Kristian Brox
2026-08-27 10:31   ` Krzysztof Kozlowski
2026-08-21  6:09 ` [PATCH v3 0/3] nfc: st-nci: Fairphone 5 NFC bring-up (ST21NFCD) Krzysztof Kozlowski
2026-08-21  9:28 ` Luca Weiss
2026-08-23 19:42   ` Kristian Brox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260827-slick-mahogany-ara-bdbd1c@quoll \
    --to=krzk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=isyourbrainfoss@proton.me \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=netdev@vger.kernel.org \
    --cc=oe-linux-nfc@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox