Re: [PATCH v10 2/3] dt-bindings: iio: dac: Add AD5529R

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Schema type mismatch for `spi-device-addr` default value.
- [Low] Schema inheritance blocked by `additionalProperties: false` in child node `patternProperties`.
--

commit 2a10366a840751ddbc9e8abde9e46cd15e15f671
Author: Janani Sunil <janani.sunil@analog.com>

dt-bindings: iio: dac: Add AD5529R

This commit introduces device tree bindings for the AD5529R 16-channel
12/16-bit high voltage digital-to-analog converter.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml
[ ... ]
> +  spi-device-addr:
> +    minItems: 1
> +    maxItems: 4
> +    items:
> +      enum: [0, 1, 2, 3]
> +    default: 0

[Severity: Low]
Will this default value cause a dt_binding_check validation failure?

The spi-device-addr property inherits its base type from
/schemas/spi/spi-peripheral-props.yaml#, which defines it as a uint32-array.
However, adi,ad5529r.yaml sets its default value to a scalar integer 0 instead
of a JSON array like [0]. dt-schema enforces type matching on default values,
so this will cause a schema compilation and validation error.

> +    description:
> +      Hardware address of each device, selected by the ID0 and ID1 pins.
> +      Up to four AD5529R devices can share a single SPI chip select.
[ ... ]
> +patternProperties:
> +  "^channel@([0-9a-f]{1,2})$":
> +    $ref: dac.yaml
> +    type: object
> +    description: Child nodes for individual channel configuration
> +
> +    properties:
> +      reg:
> +        description:
> +          Flattened channel number across all AD5529R devices sharing the chip
> +          select. Within each 16-channel block, the physical channel number is reg % 16.
> +        minimum: 0
> +        maximum: 63
> +
> +      output-range-microvolt:
[ ... ]
> +    required:
> +      - reg
> +
> +    additionalProperties: false

[Severity: Low]
Does this block properties inherited from the referenced dac.yaml schema?

The patternProperties block for child nodes uses additionalProperties: false
alongside $ref: dac.yaml. In JSON Schema, additionalProperties only applies to
properties explicitly defined in the local properties block, so it will reject
any standard properties inherited from dac.yaml (such as label) unless
unevaluatedProperties: false is used instead.

> +
> +required:
> +  - compatible

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827-ad5529r-driver-v10-0-38f2be07b824@analog.com?part=2