Re: [PATCH v2 6/7] dt-bindings: beagle: Add BeagleConnect Freedom

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The binding incorrectly enforces SPI constraints globally and rejects standard properties for non-SPI buses.
- [Medium] Typographical error in the maintainer email domain causes misdirection of patches.
--

commit c9a38c235f36e95264430893cbbb7407d8fc8ad8
Author: Ayush Singh <ayush@beagleboard.org>

dt-bindings: beagle: Add BeagleConnect Freedom

This commit adds devicetree bindings for the BeagleBoard.org BeagleConnect
Freedom board based on the TI CC1352P7. The board exposes an MCU that can
be attached to a host over USB, UART, SPI, or I2C. It also adds a new
MAINTAINERS entry for the Greybus UART node drivers.

> diff --git a/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml b/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml
> new file mode 100644
> index 0000000000000..be051a39acdc6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml
[ ... ]
> +required:
> +  - compatible
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:

[Severity: Medium]
The commit message mentions this MCU can be attached to a host over USB,
UART, SPI, or I2C. Does this unconditional reference to the SPI peripheral
properties combined with unevaluatedProperties: false prevent standard bus
properties from passing dt_binding_check?

For example, if the device is configured on a UART bus with a standard
property like current-speed = <115200>;, the toolchain will reject it because
it is not in the local schema or the referenced SPI schema. Additionally,
does this inadvertently enforce SPI constraints, such as limiting reg values
to a maximum of 256, on I2C addresses?

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 61f3fd5c509ca..a9888ace2f916 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
[ ... ]
> @@ -11271,6 +11271,12 @@ L:	greybus-dev@lists.linaro.org (moderated for non-subscribers)
>  S:	Maintained
>  F:	drivers/greybus/gb_softsvc.rs
>  
> +GREYBUS UART NODE DRIVERS
> +M:	Ayush Singh <ayush@beagleboard.com>

[Severity: Medium]
This isn't a runtime bug, but is the email address domain in the MAINTAINERS
entry correct?

The patch authorship and the dt-binding maintainer field both use
@beagleboard.org, but this entry uses @beagleboard.com. Will this cause
scripts/get_maintainer.pl to return an incorrect email address and misdirect
future patches?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827-gb-uart-transport-v2-0-a03bb1f5fbd1@beagleboard.org?part=6