From: sashiko-bot@kernel.org
To: "Steffen Trumtrar" <s.trumtrar@pengutronix.de>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: net: dp83867: make exclusivity explicit
Date: Thu, 27 Aug 2026 12:49:08 +0000 [thread overview]
Message-ID: <20260827124908.6D4071F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260826-v7-2-topic-dp83867-v2-1-a97b4cec6e93@pengutronix.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Spelling error in the commit message ('nmvem-cells').
--
commit aca94911b8a130018e97c8fe36235a2d9d984b2d
Author: Steffen Trumtrar <s.trumtrar@pengutronix.de>
dt-bindings: net: dp83867: make exclusivity explicit
This commit updates the TI DP83867 PHY binding schema to explicitly enforce
the mutual exclusivity between the nvmem-cells property and the output
impedance properties.
> Make it explicit in the schema, that nmvem-cells can not be used with
> ti,min-output-impedance or ti,max-output-impedance.
[Severity: Low]
This isn't a bug, but there is a typo (nmvem-cells) in the commit message.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-v7-2-topic-dp83867-v2-0-a97b4cec6e93@pengutronix.de?part=1
next prev parent reply other threads:[~2026-08-27 12:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 12:48 [PATCH v2 0/3] net: dp83867: add new output-impedance DT binding Steffen Trumtrar
2026-08-26 12:48 ` [PATCH v2 1/3] dt-bindings: net: dp83867: make exclusivity explicit Steffen Trumtrar
2026-08-27 12:49 ` sashiko-bot [this message]
2026-08-26 12:48 ` [PATCH v2 2/3] dt-bindings: dp83867: add binding for output-impedance Steffen Trumtrar
2026-08-26 16:01 ` Conor Dooley
2026-08-27 8:04 ` Steffen Trumtrar
2026-08-27 12:47 ` Andrew Lunn
2026-08-27 13:33 ` Steffen Trumtrar
2026-08-27 15:05 ` Andrew Lunn
2026-08-27 16:05 ` Conor Dooley
2026-08-27 12:49 ` sashiko-bot
2026-08-26 12:48 ` [PATCH v2 3/3] net: phy: dp83867: support setting output-impedance Steffen Trumtrar
2026-08-27 12:49 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827124908.6D4071F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox