From: sashiko-bot@kernel.org
To: "Laurentiu Mihalcea" <laurentiumihalcea111@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
Frank.Li@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v2 2/2] arm64: dts: freescale: add MR-NAVQ95 basic board support
Date: Thu, 27 Aug 2026 15:15:49 +0000 [thread overview]
Message-ID: <20260827151549.8815F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260827150657.1657-3-laurentiumihalcea111@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing USB configuration despite commit message claims.
- [Low] Usage of deprecated 'gpio' property in fixed-regulator
--
commit 5ca41dda85cf11b2d0c2fcf857ba3ebeca18e3d8
Author: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
arm64: dts: freescale: add MR-NAVQ95 basic board support
Add basic support for NXP's MR-NAVQ95 board. This includes features like 64GB
eMMC, up to 16GB LPDDR5, USB and RJ45 ports.
> * based on i.MX95 19x19 SoC
> * 64GB eMMC
> * up to 16GB of LPDDR5 memory
> * 1 x USB 2.0 TypeC
> * 1 x USB 3.0 TypeC
> * 1 x RJ45 port with RTL8211 PHY
[Severity: Medium]
The commit message explicitly lists '1 x USB 2.0 TypeC' and '1 x USB 3.0
TypeC' as hardware features of the board, but the device tree does not appear
to enable any USB controllers (like &usb2, &usb3) or define Type-C connectors.
Are these nodes missing from the device tree, or should the commit message be
updated to reflect the current level of implementation?
> diff --git a/arch/arm64/boot/dts/freescale/imx95-navq.dts b/arch/arm64/boot/dts/freescale/imx95-navq.dts
> new file mode 100644
> index 0000000000000..7458e77dc2ae5
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx95-navq.dts
[ ... ]
> + reg_usdhc2_vmmc: regulator-usdhc2 {
> + compatible = "regulator-fixed";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
> + regulator-name = "VDD_SD2_3V3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
[Severity: Low]
Could this use the plural "gpios" property instead? While the singular "gpio"
is still parsed by the gpiolib fallback logic, it is deprecated for new
devicetree submissions.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260827150657.1657-1-laurentiumihalcea111@gmail.com?part=2
next prev parent reply other threads:[~2026-08-27 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 15:06 [PATCH v2 0/2] Introduce basic support for MR-NAVQ95 Laurentiu Mihalcea
2026-08-27 15:06 ` [PATCH v2 1/2] dt-bindings: arm: fsl: add MR-NAVQ95 board Laurentiu Mihalcea
2026-08-27 15:06 ` [PATCH v2 2/2] arm64: dts: freescale: add MR-NAVQ95 basic board support Laurentiu Mihalcea
2026-08-27 15:15 ` sashiko-bot [this message]
2026-08-27 15:54 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827151549.8815F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=laurentiumihalcea111@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox