Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
	media-ci@linuxtv.org, imx@lists.linux.dev, robh@kernel.org,
	Frank.Li@kernel.org
Subject: Re: [PATCH v2 1/1] media: dt-bindings: move ovti,ov2659.txt into ovti,ov8858.yaml
Date: Thu, 27 Aug 2026 19:12:46 +0000	[thread overview]
Message-ID: <20260827191246.C4AD91F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260827190501.56673-1-Frank.Li@oss.nxp.com>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The commit message subject claims to move the binding into 'ovti,ov8858.yaml', but the patch actually creates 'ovti,ov2659.yaml'.
- [Low] The patch deletes the `.txt` binding but fails to update the reference in the `MAINTAINERS` file.
--

commit 87439fdf072810cc54b017765ea8976dde911644
Author: Frank Li <Frank.Li@nxp.com>

media: dt-bindings: move ovti,ov2659.txt into ovti,ov8858.yaml

Convert the OmniVision OV2659 camera sensor binding from plain text to
YAML schema format.

> media: dt-bindings: move ovti,ov2659.txt into ovti,ov8858.yaml

[Severity: Medium]
The commit message subject claims to move the binding into ovti,ov8858.yaml,
but the patch actually creates ovti,ov2659.yaml. Should the commit title be
updated to match the newly created filename?

> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt
> deleted file mode 100644
> index 92989a619f292..0000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2659.txt
> +++ /dev/null

[Severity: Low]
Does the MAINTAINERS file also need an update?

The patch deletes the text binding ovti,ov2659.txt, but it seems the
OMNIVISION OV2659 SENSOR DRIVER entry in the MAINTAINERS file was not updated
to point to the new ovti,ov2659.yaml file.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827190501.56673-1-Frank.Li@oss.nxp.com?part=1

      reply	other threads:[~2026-08-27 19:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 19:04 [PATCH v2 1/1] media: dt-bindings: move ovti,ov2659.txt into ovti,ov8858.yaml Frank.Li
2026-08-27 19:12 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260827191246.C4AD91F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=Frank.Li@oss.nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=media-ci@linuxtv.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox