Re: [PATCH v13 1/6] arm64: dts: qcom: Add device tree for Nord SoC series

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing critical thermal trip points and cooling maps in all thermal zones, preventing OS-level emergency shutdown and thermal mitigation.
--

commit deb196841a808ec3881552d5d1a8344597819e47
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

arm64: dts: qcom: Add device tree for Nord SoC series

Add base device tree include (nord.dtsi) for the Nord SoC series
describing the core hardware components.

> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> new file mode 100644
> index 0000000000000..e0496fd40c308
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi
[ ... ]
> +		cpu-0-0-0-thermal {
> +			polling-delay-passive = <0>;
> +			polling-delay = <0>;
> +			thermal-sensors = <&tsens0 1>;
> +
> +			trips {
> +				trip-point0 {
> +					temperature = <105000>;
> +					hysteresis = <10000>;
> +					type = "passive";
> +				};
> +
> +				trip-point1 {
> +					temperature = <125000>;
> +					hysteresis = <10000>;
> +					type = "passive";
> +				};
> +			};
> +		};

[Severity: High]
Is it intended that this thermal zone, as well as the others defined in this
file, lacks a critical trip point?

Without a critical trip point, the OS will not be able to trigger an emergency
shutdown if temperatures exceed safe limits. Additionally, the defined passive
trip points lack corresponding cooling-maps, meaning no thermal mitigation
(such as CPU throttling) will occur when these thresholds are reached.

Should critical trip points and appropriate cooling maps be added to ensure the
OS can properly manage hardware temperatures?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828034958.3165-1-shengchao.guo@oss.qualcomm.com?part=1