Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Moving `qcom,glymur-dwc3` to a different `if-then` conditional block changes the positional requirements of the `interrupt-names` array, breaking ABI and schema validation for existing device trees.
--

commit 15d826b7f9c1b0ac7d9038a76e721573a86a768f
Author: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>

dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

This commit modifies the device tree binding for the Glymur non-multiport
USB controllers to allow a maximum of 6 interrupts. It moves the compatible
string to a different conditional block to accommodate both hs_phy_irq and
ss_phy_irq.

Link: https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/

> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> index ea60f7220afe3..3bef18f9557e1 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml

[ ... ]

> @@ -547,6 +546,7 @@ allOf:
>            contains:
>              enum:
>                - qcom,eliza-dwc3
> +              - qcom,glymur-dwc3

[Severity: High]
Does moving this compatible string to the qcom,eliza-dwc3 conditional block
inadvertently break the device tree schema ABI for existing platforms?

The original qcom,milos-dwc3 block matched the baseline interrupt sequence
used by existing device trees, requiring dp_hs_phy_irq at index 2:

allOf / if block for qcom,milos-dwc3:
        interrupt-names:
          minItems: 4
          items:
            - const: dwc_usb3
            - const: pwr_event
            - const: dp_hs_phy_irq

The target qcom,eliza-dwc3 block imposes a different positional requirement,
expecting hs_phy_irq at index 2 and dp_hs_phy_irq at index 3:

allOf / if block for qcom,eliza-dwc3:
        interrupt-names:
          minItems: 5
          items:
            - const: dwc_usb3
            - const: pwr_event
            - const: hs_phy_irq
            - const: dp_hs_phy_irq

Looking at existing configurations, such as usb_0 in
arch/arm64/boot/dts/qcom/glymur.dtsi, the layout defines dp_hs_phy_irq
as the third interrupt:

arch/arm64/boot/dts/qcom/glymur.dtsi:usb_0 {
                interrupt-names = "dwc_usb3",
                                  "pwr_event",
                                  "dp_hs_phy_irq",
                                  "dm_hs_phy_irq",
                                  "ss_phy_irq";
}

Since JSON schema arrays evaluate items positionally, won't this change
cause existing in-tree device trees to fail dtbs_check validation?

>                - qcom,ipq4019-dwc3
>                - qcom,ipq8064-dwc3
>                - qcom,kaanapali-dwc3

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828081542.52796-1-krishna.kurapati@oss.qualcomm.com?part=1