Re: [PATCH v7 1/2] dt-bindings: input: Add Qualcomm SPMI PMIC haptics

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new `haptics` device tree node will cause validation failures because it is not permitted by its parent MFD schema.
--

commit 69b46ca6dd857a336fadfc81c3a26d260c9c10ea
Author: Fenglin Wu <fenglin.wu@oss.qualcomm.com>

dt-bindings: input: Add Qualcomm SPMI PMIC haptics

Add binding document for the haptics module inside Qualcomm PMIC PMIH0108.

> diff --git a/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml b/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml
> new file mode 100644
> index 0000000000000..ce2c9e893a0d7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/spmi/spmi.h>
> +
> +    pmic@7 {
> +        compatible = "qcom,pmih0108", "qcom,spmi-pmic";
> +        reg = <0x7 SPMI_USID>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        haptics@f000 {
> +            compatible = "qcom,pmih0108-haptics", "qcom,spmi-haptics";

[Severity: Low]
Will the haptics child node cause device tree validation failures against the
parent MFD schema?

The parent schema for qcom,spmi-pmic enforces additionalProperties: false,
but it does not define a patternProperties regular expression that permits
a haptics node. Running dt_binding_check or dtbs_check on this example, or
any actual device tree using this node under the SPMI PMIC, will fail
validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828-qcom-spmi-haptics-v7-0-0367b3ac2e1e@oss.qualcomm.com?part=1