From: sashiko-bot@kernel.org
To: "Thierry Reding" <thierry.reding@kernel.org>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 3/3] arm64: tegra: Add cooling device on Jetson AGX Thor DevKit
Date: Fri, 28 Aug 2026 12:05:30 +0000 [thread overview]
Message-ID: <20260828120530.EBDDA1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260828-tegra264-fan-v2-3-a460389d8ef5@nvidia.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The 'pwm@c6a0000' node incorrectly reuses the unit address of the 'i2c9' ('i2c@c6a0000') node defined in the base SoC dtsi, and lacks required compatible/reg properties.
- [Low] The device tree references an undefined label '&pwm4' in the 'pwms' property of the 'pwm-fan' node, causing a DTC compilation failure.
--
commit 73950943498e73365e307610b1d8975ecc5959a4
Author: Thierry Reding <treding@nvidia.com>
arm64: tegra: Add cooling device on Jetson AGX Thor DevKit
Monitor the TJ thermal zone and use the main PWM fan of the Jetson AGX
Thor Developer Kit to actively cool the device if needed.
[ ... ]
> diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi
> index 4550e843f513c..dd042e57839a5 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi
[Severity: Medium]
Will the pwm@c6a0000 node in this file create a node name collision at unit
address @c6a0000?
Looking at the node definition in this file:
bus@0 {
pwm@c6a0000 {
status = "okay";
};
};
Could this incorrectly reuse the unit address of the i2c9 (i2c@c6a0000) node
defined in the base SoC dtsi?
Additionally, this node lacks the compatible and reg properties. Will this
prevent the PWM hardware from probing, leaving the newly added fan feature
unconfigured?
> @@ -22,4 +22,56 @@ fan: pwm-fan {
> pwms = <&pwm4 0 40000>;
[Severity: Low]
Can this undefined label cause a DTC compilation failure?
Since the base tegra264.dtsi does not define a pwm4 label, will this break
the kernel build with a "Reference to non-existent node or label" error
when building the DTB?
> #cooling-cells = <2>;
> };
> +
> + thermal-zones {
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260828-tegra264-fan-v2-0-a460389d8ef5@nvidia.com?part=3
prev parent reply other threads:[~2026-08-28 12:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 11:51 [PATCH v2 0/3] arm64: tegra: Add cooling device on Jetson AGX Thor DevKit Thierry Reding
2026-08-28 11:51 ` [PATCH v2 1/3] arm64: tegra: Add PWM fan " Thierry Reding
2026-08-28 12:03 ` sashiko-bot
2026-08-28 11:51 ` [PATCH v2 2/3] arm64: tegra: Add thermal zones for Tegra264 Thierry Reding
2026-08-28 11:51 ` [PATCH v2 3/3] arm64: tegra: Add cooling device on Jetson AGX Thor DevKit Thierry Reding
2026-08-28 12:05 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828120530.EBDDA1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox