Re: [PATCH 01/11] arm64: dts: qcom: sm8550: Disable Inline Crypto Engine by default

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Disabling the Inline Crypto Engine (ICE) node by default in the SoC DTSI causes UFS probe to fail for any board that enables UFS without explicitly enabling ICE, breaking backward compatibility.
--

commit 16a0192ad11b331cfd04d9e22cced4ae705ad4f3
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: sm8550: Disable Inline Crypto Engine by default

Since UFS_PHY_GDSC is attached to the Inline Crypto Engine and the driver
does not currently enable runtime PM, the GDSC remains enabled while the
device is idle, even on boards where there are no consumers.

So disable the Inline Crypto Engine by default in the SoC DTSI and enable
it only in board DTS files that use it.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 0e701e709235c..a2bfd857f3fc0 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2840,6 +2840,8 @@ ice: crypto@1d88000 {
>  			clock-names = "core",
>  				      "iface";
>  			power-domains = <&gcc UFS_PHY_GDSC>;
> +
> +			status = "disabled";

[Severity: High]
Does disabling the ICE node by default break backward compatibility for
boards that enable UFS without explicitly enabling ICE?

Since the qcom,ice phandle is retained in the ufs_mem_hc node, when a
board doesn't explicitly set status = "okay" for the ICE node,
of_find_device_by_node() will return NULL for the disabled node.

This causes of_qcom_ice_get() to return -ENODEV instead of -EOPNOTSUPP:

drivers/soc/qcom/ice.c:of_qcom_ice_get() {
    ...
	pdev = of_find_device_by_node(node);
	if (!pdev) {
		dev_err(dev, "Cannot find device node %s\n", node->name);
		return ERR_PTR(-ENODEV);
	}
    ...
}

Because it returns -ENODEV, the UFS driver treats this as a hard error and
aborts the entire UFS probe, rather than gracefully degrading without inline
encryption:

drivers/ufs/host/ufs-qcom.c:ufs_qcom_ice_init() {
    ...
	ice = devm_of_qcom_ice_get(dev);
	if (IS_ERR(ice)) {
		if (ice != ERR_PTR(-EOPNOTSUPP))
			return PTR_ERR(ice);
    ...
}

Could this prevent the system from booting if the root filesystem is on UFS?

>  		};
>  
>  		tcsr_mutex: hwlock@1f40000 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828-b4-dts-qcom-disable-ice-by-default-v1-0-1d6e0c2f5a69@oss.qualcomm.com?part=1