From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A1FB44E042 for ; Fri, 28 Aug 2026 14:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787926240; cv=none; b=nRy7L7WSBDrnfK7sQoGHHdVZwlGb9VbrfHIW789bw2ciKKnS4oANO+31QFjQ5NIvVSg67pEmF8PJLs00effRZfJpLfVueFQFHE7CM7PU3FUB+TGNW/vNPkYm5bempNgGbrgh2waJbkWI284yR5I+vML/+j8ygNRwSHHvISbEWXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787926240; c=relaxed/simple; bh=WyMeMkfMMHzJ+0sb0THOg9EpsNe2lQCijuTfim0kx3Y=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ZoTph+Ex0GRYxEn5ynhEK0Py1b8qWgXPxHkbdMJ1KHA8UDWeFE+/BwdPk5WeBAiut/VUHvSXng1hjDsWOv6Ya/oltPFXJFPrt+wfoSK5daZBSGgcudEZR853q/3KQ0/aJi2ynZLyCAe8F4NnU25w/buTpkXfR/f2QsQt9NE14D4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MTlgD2uc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MTlgD2uc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF3071F000E9; Fri, 28 Aug 2026 14:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787926232; bh=kN/aO+fEV+5N9m7w1YSrShQLZqxSBlJh3DH/IOCjG6M=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=MTlgD2ucg9538IPQCaIqu+jzGJiJf3pPRHEl0J4hYYqWpdaTIzAEKRWMP1OpsHSAk a4QoWvLrz4jJWFLMU3E9hfNH5yj8XJk1byyzvK1++hwliVUdgj05opE2mNr1CCRRqV u+ptIUJ2sgd602am15eLKHt9uZuJvUdUlA0RSBl3bnxMfoMJVH5dPsSy7BYS/86dv8 dRIS9eLC+gfik4ZUd2smLI/b0IgME6RTRfPaYW/VO5cOUgbL5p33I5hR85WGqlIcsi EzU5fBz1Q30GYYir3BzpwaM+qGzVEbT7aY7ts/92DAoxfhw7+6icnzVG3UyedecRv8 Fmi7kMLfE+NMg== From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC/DO NOT MERGE 06/12] dt-bindings: display/msm: eliza-hdmi-phy: Add Eliza HDMI PHY Reply-To: sashiko-reviews@lists.linux.dev To: "Krzysztof Kozlowski" Cc: robh@kernel.org, vkoul@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com, dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org In-Reply-To: <20260828-drm-msm-hdmi-eliza-v1-6-67843277de17@oss.qualcomm.com> References: <20260828-drm-msm-hdmi-eliza-v1-0-67843277de17@oss.qualcomm.com> <20260828-drm-msm-hdmi-eliza-v1-6-67843277de17@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 28 Aug 2026 14:10:31 +0000 Message-Id: <20260828141031.CF3071F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Devicetree unit address mismatch in schema example. -- commit 2063c7e805b5b72143440af38f64d666c647dad5 Author: Krzysztof Kozlowski dt-bindings: display/msm: eliza-hdmi-phy: Add Eliza HDMI PHY This commit adds the device tree binding for the Synopsys HDMI PHY found on the Qualcomm Eliza SoC. It documents the required properties and provides an example device node. > diff --git a/Documentation/devicetree/bindings/phy/qcom,eliza-hdmi-phy.ya= ml b/Documentation/devicetree/bindings/phy/qcom,eliza-hdmi-phy.yaml > new file mode 100644 > index 0000000000000..764fec0ef29bf > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,eliza-hdmi-phy.yaml [ ... ] > +examples: > + - | > + #include > + #include > + #include > + > + hdmi-phy@9a0600 { > + compatible =3D "qcom,eliza-hdmi-phy"; > + reg =3D <0x0aea1000 0x1000>; [Severity: Low] Does this unit address in the node name mismatch the first address in the reg property? Running make dt_binding_check will likely trigger a unit_address_vs_reg warning regression because the node is named hdmi-phy@9a0600 but its reg property sets the base address to 0x0aea1000. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260828-drm-msm-hd= mi-eliza-v1-0-67843277de17@oss.qualcomm.com?part=3D6