From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: usb: generic-ohci: Document ST STM32MP1 SoC compatibles
Date: Fri, 28 Aug 2026 15:09:13 +0000 [thread overview]
Message-ID: <20260828150913.A43F11F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260828150202.173109-1-marex@nabladev.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete binding family update: missing STM32MP1 EHCI compatibles.
--
commit b94b8c4a5c06e677f1c40f017de92bb5e2ec3002
Author: Marek Vasut <marex@nabladev.com>
dt-bindings: usb: generic-ohci: Document ST STM32MP1 SoC compatibles
This commit documents the SoC-specific compatibles for the ST STM32MP13xx
and STM32MP15xx series in the generic-ohci binding. This allows the SoC
DTSI to use these more accurate compatibles instead of just the generic
fallback.
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index d42f448fa2044..1b54f0d91061f 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -49,6 +49,8 @@ properties:
> - ingenic,jz4740-ohci
> - rockchip,rk3588-ohci
> - snps,hsdk-v1.0-ohci
> + - st,stm32mp13-ohci
> + - st,stm32mp15-ohci
[Severity: Medium]
Since st,stm32mp13-ohci and st,stm32mp15-ohci are being added here, should
the companion EHCI compatibles (st,stm32mp13-ehci and st,stm32mp15-ehci)
also be added to the compatible block in
Documentation/devicetree/bindings/usb/generic-ehci.yaml?
The device tree bindings subsystem guidelines state that when a binding
has multiple YAML files for different device types in the same family,
related files need matching updates. Updating generic-ehci.yaml would
ensure the EHCI companion controller is documented alongside its OHCI
counterpart, keeping the entire USB host subsystem on STM32MP1 fully
documented and future-proofed.
> - const: generic-ohci
> - enum:
> - generic-ohci
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260828150202.173109-1-marex@nabladev.com?part=1
prev parent reply other threads:[~2026-08-28 15:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 15:01 [PATCH 1/3] dt-bindings: usb: generic-ohci: Document ST STM32MP1 SoC compatibles Marek Vasut
2026-08-28 15:01 ` [PATCH 2/3] ARM: dts: stm32: Use STM32MP13xx compatible string for OHCI USB controller Marek Vasut
2026-08-28 15:01 ` [PATCH 3/3] ARM: dts: stm32: Use STM32MP15xx " Marek Vasut
2026-08-28 15:09 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828150913.A43F11F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=marex@nabladev.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox