From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles
Date: Fri, 28 Aug 2026 15:10:29 +0000 [thread overview]
Message-ID: <20260828151029.8DEB01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260828150245.173147-1-marex@nabladev.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Alphabetical ordering violation in compatible strings list.
--
commit 02866cad5ea0e6cf3b7ff32996fc2ff6f326adb3
Author: Marek Vasut <marex@nabladev.com>
dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles
This commit adds SoC-specific compatible strings for the ST STM32MP13xx and
STM32MP15xx series to the generic-ehci device tree binding. This allows for
more accurate compatible matching in the SoC DTSI files.
> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> index 55a5aa7d7a54e..408f9860d8079 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -54,6 +54,8 @@ properties:
> - qca,ar7100-ehci
> - rockchip,rk3588-ehci
> - snps,hsdk-v1.0-ehci
> + - st,stm32mp13-ehci
> + - st,stm32mp15-ehci
> - socionext,uniphier-ehci
[Severity: Low]
This isn't a bug, but should these compatible strings be sorted
alphabetically? Since st comes after socionext, it looks like the st,stm32
compatibles should be placed after the socionext,uniphier-ehci entry to
maintain the standard alphabetical ordering.
> - const: generic-ehci
> - items:
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260828150245.173147-1-marex@nabladev.com?part=1
prev parent reply other threads:[~2026-08-28 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 15:02 [PATCH 1/3] dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles Marek Vasut
2026-08-28 15:02 ` [PATCH 2/3] ARM: dts: stm32: Use STM32MP13xx compatible string for EHCI USB controller Marek Vasut
2026-08-28 15:02 ` [PATCH 3/3] ARM: dts: stm32: Use STM32MP15xx " Marek Vasut
2026-08-28 15:10 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828151029.8DEB01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=marex@nabladev.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox