From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Saravana Kannan <saravanak@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: [PATCH 1/6] dtc: dt-check-style: Sort rule directory by name
Date: Sat, 29 Aug 2026 21:53:17 +0200 [thread overview]
Message-ID: <20260829-dts-style-checker-sort-v1-1-6693a37d7ae1@oss.qualcomm.com> (raw)
In-Reply-To: <20260829-dts-style-checker-sort-v1-0-6693a37d7ae1@oss.qualcomm.com>
Sort the array with all the rules, so managing this will be at bit
easier and simultaneous addons of new rules less conflict-prone. No
functional changes.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
scripts/dtc/dt-check-style | 95 +++++++++++++++++++++++-----------------------
1 file changed, 48 insertions(+), 47 deletions(-)
diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
index 487e76b85105..49b5c28563eb 100755
--- a/scripts/dtc/dt-check-style
+++ b/scripts/dtc/dt-check-style
@@ -1036,22 +1036,7 @@ RULES = [
# 'relaxed' is the default; rules in this group must produce zero
# output on a clean kernel tree (post the small prep-cleanup
# commit at the head of this series).
- Rule('trailing-whitespace', 'relaxed',
- 'no trailing whitespace on any line',
- check_trailing_whitespace),
- # See also check_redundant_whitespace_strict() and check_value_whitespace()
- Rule('redundant-whitespace', 'relaxed',
- 'no redundant whitespace within code',
- check_redundant_whitespace),
- Rule('tab-in-yaml', 'relaxed',
- 'YAML (also DTS examples) may not contain tab characters',
- check_tab_in_yaml_example, applies_to=('yaml',)),
- Rule('mixed-indent-chars', 'relaxed',
- 'indent must not mix tabs and spaces',
- check_mixed_indent_chars, applies_to=('dts', 'dtsi', 'dtso')),
- Rule('unclosed-block-comment', 'relaxed',
- 'every /* block comment must close with */',
- check_unclosed_block_comment),
+ # Rules are sorted here by group (relaxed, strict, stricter) and name
# DTS files always use tabs; this is not negotiable per kernel
# coding style (.dts files are real source). Relaxed mode.
@@ -1059,19 +1044,26 @@ RULES = [
'DTS files: 1 tab per nesting level',
check_indent_unit_dts,
applies_to=('dts', 'dtsi', 'dtso')),
+ Rule('mixed-indent-chars', 'relaxed',
+ 'indent must not mix tabs and spaces',
+ check_mixed_indent_chars, applies_to=('dts', 'dtsi', 'dtso')),
+ # See also check_redundant_whitespace_strict() and check_value_whitespace()
+ Rule('redundant-whitespace', 'relaxed',
+ 'no redundant whitespace within code',
+ check_redundant_whitespace),
+ Rule('tab-in-yaml', 'relaxed',
+ 'YAML (also DTS examples) may not contain tab characters',
+ check_tab_in_yaml_example, applies_to=('yaml',)),
+ Rule('trailing-whitespace', 'relaxed',
+ 'no trailing whitespace on any line',
+ check_trailing_whitespace),
+ Rule('unclosed-block-comment', 'relaxed',
+ 'every /* block comment must close with */',
+ check_unclosed_block_comment),
# 'strict' rules are opt-in (e.g. for new submissions via
# checkpatch.pl in a follow-up series). They flag many existing
# files and can be promoted to relaxed once those are cleaned up.
- Rule('indent-unit', 'strict',
- 'YAML: 2 or 4 spaces per level',
- check_indent_unit_relaxed, applies_to=('yaml',)),
- Rule('indent-unit-strict', 'strict',
- 'YAML: must be 4 spaces per level',
- check_indent_unit_strict, applies_to=('yaml',)),
- Rule('indent-consistent', 'strict',
- 'every line indented at depth * unit',
- check_indent_consistent),
Rule('blank-lines', 'strict',
'no consecutive blanks; no blanks at node body edges',
check_blank_lines),
@@ -1081,37 +1073,43 @@ RULES = [
Rule('child-name-order', 'strict',
'unaddressed siblings must be in natural-sort name order',
check_child_name_order),
- Rule('property-order', 'strict',
- 'canonical bucket + pairing + natural-sort order of properties',
- check_property_order),
- Rule('required-blank-lines', 'strict',
- 'blank line before child nodes and before "status"',
- check_required_blank_lines),
+ Rule('continuation-alignment', 'strict',
+ 'multi-line property continuations align under <, " or the value under <',
+ check_continuation_alignment),
Rule('hex-case', 'strict',
'hex literals must be lowercase',
check_hex_case),
- Rule('unit-address-format', 'strict',
- 'unit addresses must be lowercase hex without leading zeros',
- check_unit_address_format),
- # See also check_redundant_whitespace() and check_value_whitespace()
- Rule('redundant-whitespace-strict', 'strict',
- 'no redundant whitespace within code',
- check_redundant_whitespace_strict),
- Rule('value-whitespace', 'strict',
- 'no whitespace directly inside <...> brackets',
- check_value_whitespace),
- Rule('node-close-alone', 'strict',
- 'closing brace must be on its own line',
- check_node_close_alone),
+ Rule('indent-consistent', 'strict',
+ 'every line indented at depth * unit',
+ check_indent_consistent),
+ Rule('indent-unit', 'strict',
+ 'YAML: 2 or 4 spaces per level',
+ check_indent_unit_relaxed, applies_to=('yaml',)),
+ Rule('indent-unit-strict', 'strict',
+ 'YAML: must be 4 spaces per level',
+ check_indent_unit_strict, applies_to=('yaml',)),
Rule('line-length', 'strict',
'lines must not exceed 80 columns',
check_line_length, applies_to=('yaml',)),
Rule('line-length-dts', 'stricter',
'lines must not exceed 80 columns',
check_line_length, applies_to=('dts', 'dtsi', 'dtso')),
- Rule('continuation-alignment', 'strict',
- 'multi-line property continuations align under <, " or the value under <',
- check_continuation_alignment),
+ Rule('node-close-alone', 'strict',
+ 'closing brace must be on its own line',
+ check_node_close_alone),
+ Rule('property-order', 'strict',
+ 'canonical bucket + pairing + natural-sort order of properties',
+ check_property_order),
+ # See also check_redundant_whitespace() and check_value_whitespace()
+ Rule('redundant-whitespace-strict', 'strict',
+ 'no redundant whitespace within code',
+ check_redundant_whitespace_strict),
+ Rule('required-blank-lines', 'strict',
+ 'blank line before child nodes and before "status"',
+ check_required_blank_lines),
+ Rule('unit-address-format', 'strict',
+ 'unit addresses must be lowercase hex without leading zeros',
+ check_unit_address_format),
Rule('unused-labels', 'strict',
'every label must be &-referenced in the same example/file '
'(skipped for .dtsi/.dtso since labels there are exported)',
@@ -1120,6 +1118,9 @@ RULES = [
'every label must be &-referenced in the same example/file '
'(skipped for .dtsi/.dtso since labels there are exported)',
check_unused_labels, applies_to=('dts',)),
+ Rule('value-whitespace', 'strict',
+ 'no whitespace directly inside <...> brackets',
+ check_value_whitespace),
]
--
2.53.0
next prev parent reply other threads:[~2026-08-29 19:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 19:53 [PATCH 0/6] dtc: dt-check-style: Cleanup plus new checks Krzysztof Kozlowski
2026-08-29 19:53 ` Krzysztof Kozlowski [this message]
2026-08-29 19:53 ` [PATCH 2/6] dtc: dt-check-style: Sort rule functions by name Krzysztof Kozlowski
2026-08-29 19:53 ` [PATCH 3/6] dtc: dt-check-style: Process property names with a question mark Krzysztof Kozlowski
2026-08-29 19:53 ` [PATCH 4/6] dtc: dt-check-style: Add test for node and property name styles Krzysztof Kozlowski
2026-08-30 19:59 ` Rob Herring
2026-08-30 20:57 ` Krzysztof Kozlowski
2026-08-31 17:58 ` Rob Herring
2026-08-29 19:53 ` [PATCH 5/6] dtc: dt-check-style: Check for indentation also in continued lines of DTS Krzysztof Kozlowski
2026-08-29 19:53 ` [PATCH 6/6] dtc: dt-check-style: Check for indentation also in continued lines of bindings example Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260829-dts-style-checker-sort-v1-1-6693a37d7ae1@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox