From: Dale Whinham <daleyo@gmail.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Jérôme de Bretagne" <jerome.debretagne@gmail.com>,
"Dale Whinham" <daleyo@gmail.com>
Subject: [PATCH] arm64: dts: qcom: x1-denali: Add volume up/down GPIO keys
Date: Sat, 29 Aug 2026 19:41:30 +0100 [thread overview]
Message-ID: <20260829-surface-pro-11-volume-buttons-v1-1-ace589343a68@gmail.com> (raw)
Configure gpio6 and gpio8 as volume up and volume down respectively, to
enable the volume rocker located at the top of the screen.
Signed-off-by: Dale Whinham <daleyo@gmail.com>
---
arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi | 36 ++++++++++++++++++++++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi b/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi
index 7559557610ed..c467f61545cb 100644
--- a/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi
@@ -20,7 +20,7 @@ aliases {
gpio-keys {
compatible = "gpio-keys";
- pinctrl-0 = <&hall_int_n_default>;
+ pinctrl-0 = <&hall_int_n_default>, <&vol_down_n>, <&vol_up_n>;
pinctrl-names = "default";
switch-lid {
@@ -30,6 +30,24 @@ switch-lid {
wakeup-source;
wakeup-event-action = <EV_ACT_DEASSERTED>;
};
+
+ key-vol-down {
+ debounce-interval = <15>;
+ gpios = <&pm8550_gpios 8 GPIO_ACTIVE_LOW>;
+ label = "Volume Down";
+ linux,can-disable;
+ linux,code = <KEY_VOLUMEDOWN>;
+ wakeup-source;
+ };
+
+ key-vol-up {
+ debounce-interval = <15>;
+ gpios = <&pm8550_gpios 6 GPIO_ACTIVE_LOW>;
+ label = "Volume Up";
+ linux,can-disable;
+ linux,code = <KEY_VOLUMEUP>;
+ wakeup-source;
+ };
};
pmic-glink {
@@ -995,6 +1013,22 @@ rtmr0_3p3_reg_en: rtmr0-3p3-reg-en-state {
function = "normal";
power-source = <1>; /* 1.8V */
};
+
+ vol_down_n: vol-down-n-state {
+ bias-pull-up;
+ input-enable;
+ pins = "gpio8";
+ function = "normal";
+ power-source = <1>; /* 1.8V */
+ };
+
+ vol_up_n: vol-up-n-state {
+ bias-pull-up;
+ input-enable;
+ pins = "gpio6";
+ function = "normal";
+ power-source = <1>; /* 1.8V */
+ };
};
&pm8550ve_9_gpios {
---
base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
change-id: 20260829-surface-pro-11-volume-buttons-f4b40e25cecb
Best regards,
--
Dale Whinham <daleyo@gmail.com>
next reply other threads:[~2026-08-29 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 18:41 Dale Whinham [this message]
2026-08-31 7:13 ` [PATCH] arm64: dts: qcom: x1-denali: Add volume up/down GPIO keys Konrad Dybcio
2026-08-31 15:51 ` Dale Whinham
2026-09-02 16:24 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260829-surface-pro-11-volume-buttons-v1-1-ace589343a68@gmail.com \
--to=daleyo@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jerome.debretagne@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox