From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document PMAU0102 GPIO support
Date: Sun, 30 Aug 2026 04:39:24 +0000 [thread overview]
Message-ID: <20260830043925.3B6141F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260830042939.144376-2-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing main PMIC compatible string ('qcom,pmau0102') in the parent SPMI PMIC MFD binding schema.
--
commit 3791c0eb2161c16b2bc2d4e00e3124ab371b06be
Author: Dhruvin Rajpura <drajpura@qti.qualcomm.com>
dt-bindings: pinctrl: qcom,pmic-gpio: Document PMAU0102 GPIO support
Add compatible string for the PMAU0102 PMIC GPIO block, which has 12
GPIOs, used on Nord platform.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index c27e24cb206fc..77be0690c751a 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -57,6 +57,7 @@ properties:
> - qcom,pm8994-gpio
> - qcom,pm8998-gpio
> - qcom,pma8084-gpio
> + - qcom,pmau0102-gpio
[Severity: Medium]
Does the parent SPMI PMIC MFD binding schema also need to be updated?
The child GPIO node is being documented here, which implies the parent PMIC MFD
binding must also be updated with the main PMIC compatible string
(qcom,pmau0102).
If a device tree adds a node for the PMAU0102 PMIC using compatible =
"qcom,pmau0102", "qcom,spmi-pmic" and its child GPIO node, the parent node will
fail schema validation against qcom,spmi-pmic.yaml because it is undocumented.
Should the qcom,pmau0102 compatible string be added to
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260830042939.144376-1-shengchao.guo@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-08-30 4:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 4:29 [PATCH 0/2] pinctrl: qcom: Add PMAU0102 GPIO support Shawn Guo
2026-08-30 4:29 ` [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Document " Shawn Guo
2026-08-30 4:39 ` sashiko-bot [this message]
2026-08-31 9:31 ` Krzysztof Kozlowski
2026-08-30 4:29 ` [PATCH 2/2] pinctrl: qcom: spmi-gpio: Add " Shawn Guo
2026-09-02 10:24 ` [PATCH 0/2] pinctrl: qcom: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260830043925.3B6141F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox