From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E729C3D47AF for ; Mon, 31 Aug 2026 08:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788166730; cv=none; b=iAgxO85A7lw1jGbKAJQuAHg2YEufc0CzMok7gQiOGIUs7FyXGd1UPU6JM0atxcYkuDzDLaHY8xVmteuaNUJxenScdpL73WNPBPRKbieyECPyzqm9yPIhk5c6QPt84y2TAcDl6fosnHGghbK41RClPHTqx4Uoc34aMfxyse4+mR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788166730; c=relaxed/simple; bh=rrEU7lKUh5e1QMvL0R5xj6lhGNibJ7XogO+cKLGI5Kc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=oP6KY6SMjuxFjCjNtTBprYf3flldE1GH1OmOB3NCpgHR0hExLaDhDKhDRNnUkclPd3l0xoh4CpKc+vDaGzdVGej7qzDGcw/sEl+3JBwNYsZbEN8449lU0SVMeZPfsBOBoIZKD02w8PxToO/8rT7WwqtLFFsncNi2tVEC3M8BtUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ViCaYuwN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ViCaYuwN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29FC51F000E9; Mon, 31 Aug 2026 08:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788166728; bh=euwWm0YtT9El1dw8+Zh2LaSdk0rBvB862z9nvBMbyTU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ViCaYuwNC/Vu5yh9TLCL2+bVlME9osXcTAyn9FaNa9sFCtwgs74vKvSnaRmg83Kol SQOcgSuvOn6aDTzbK/JU3M3W5i9/Iaeyz5dJ2++sqxe0jMqrhh79B2RCpOicDL1HfE 3f/UXAqTr9t4o7G0/5PiLI3Cp4huxUaorYEQKRKtxw5VuZLQ2wFjQc/NJvm7m6XPP8 K5UXAWNYL/ZV1sDzV4wOkHH4yEoiM+frNTHeTqYdKSlX/6T6ky1l3yPe06DfhEEpZp 4gEKQpNRZqmBk9MhkhboNPJm5PgAI8r56tiB1qRAhwkxM5QvvGF3R1OGYlStEYbilT Tgx7KHrsongYQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC Reply-To: sashiko-reviews@lists.linux.dev To: "Zhentao Guo" Cc: media-ci@linuxtv.org, linux-amlogic@lists.infradead.org, robh@kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260831-b4-s4-vdec-upstream-v8-6-830195b9bd91@amlogic.com> References: <20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com> <20260831-b4-s4-vdec-upstream-v8-6-830195b9bd91@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 31 Aug 2026 08:58:47 +0000 Message-Id: <20260831085848.29FC51F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The new defconfig entry CONFIG_VIDEO_AMLOGIC_VDEC is not placed in = the correct order as it would be generated by `make savedefconfig`. -- commit c64b548261f0711290a36c1bf013f8ce20bd9e1e Author: Zhentao Guo arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC This commit enables the Amlogic V4L2 stateless video decoder driver as a module in the arm64 defconfig to support the Amlogic S4 platform. > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 6ec8d3a69c98e..7be4e5a284bab 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -919,6 +919,7 @@ CONFIG_V4L_PLATFORM_DRIVERS=3Dy > CONFIG_SDR_PLATFORM_DRIVERS=3Dy > CONFIG_V4L_MEM2MEM_DRIVERS=3Dy > CONFIG_VIDEO_AMPHION_VPU=3Dm > +CONFIG_VIDEO_AMLOGIC_VDEC=3Dm [Severity: Low] Is this config placed out of order? In kernel development, defconfig files must be updated using make savedefconfig to ensure entries are sorted according to Kconfig parsing order. In drivers/media/platform/Kconfig, amlogic/Kconfig is sourced before amphion/Kconfig. Therefore, CONFIG_VIDEO_AMLOGIC_VDEC should appear before CONFIG_VIDEO_AMPHION_VPU. Could this be updated via make savedefconfig to avoid deviating from the strict Kconfig tree order and prevent unnecessary churn or merge conflicts in the future? > CONFIG_VIDEO_CADENCE_CSI2RX=3Dm > CONFIG_VIDEO_WAVE_VPU=3Dm > CONFIG_VIDEO_E5010_JPEG_ENC=3Dm --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260831-b4-s4-vdec= -upstream-v8-0-830195b9bd91@amlogic.com?part=3D6