Re: [PATCH v2] arm64: dts: qcom: sc8280xp: Add more thermal zones

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The NSP (Neural Processing Unit) thermal zone node names have swapped suffixes relative to their tsens instances.
--

commit 092e957a85480db5b06f08e884f71660fcf25523
Author: Xilin Wu <sophon@radxa.com>

arm64: dts: qcom: sc8280xp: Add more thermal zones

This commit adds thermal zones for the remaining undocumented TSENS sensors
on the SC8280XP. It includes missing NSP1 thermal zones and renames CPUSS
and DDRSS thermal zones.

Link: https://patch.msgid.link/20260507-sc8280xp-thermal-zones-v1-0-33d4395b1be9@radxa.com

> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index fbcfd3883bbb4..880570d0a41c6 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi

[ ... ]

> +		cpuss1-thermal {
> +			thermal-sensors = <&tsens1 9>;
> +
> +			trips {
> +				cpu-crit {
> +					temperature = <110000>;
> +					hysteresis = <1000>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +
> +		nsp0-2-thermal {
> +			thermal-sensors = <&tsens1 10>;

[Severity: Low]
Is this node name suffix intentional? The naming convention throughout this
file appears to use the tsens instance index as the suffix for the thermal
zone node name (e.g., aoss-1-thermal uses tsens1), but here nsp0-2-thermal
maps to tsens1.

> +
> +			trips {
> +				nsp0-crit {
> +					temperature = <110000>;
> +					hysteresis = <1000>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +
> +		nsp1-2-thermal {
> +			thermal-sensors = <&tsens1 11>;

[Severity: Low]
Similarly, should this be named nsp1-1-thermal to match the tsens1 instance
it uses?

[ ... ]

> +		video-thermal {
> +			thermal-sensors = <&tsens2 8>;
> +
> +			trips {
> +				video-crit {
> +					temperature = <110000>;
> +					hysteresis = <1000>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +
> +		nsp0-1-thermal {
> +			thermal-sensors = <&tsens2 9>;

[Severity: Low]
Should this node be named nsp0-2-thermal to match tsens2? Currently, the -1
and -2 node suffixes appear to be swapped relative to their tsens instances.

> +
> +			trips {
> +				nsp0-crit {
> +					temperature = <110000>;
> +					hysteresis = <1000>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +
> +		nsp1-1-thermal {
> +			thermal-sensors = <&tsens2 10>;

[Severity: Low]
As with the nodes above, does this nsp1-1-thermal node incorrectly map
to tsens2 instead of tsens1 due to the swapped suffixes?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-sc8280xp-thermal-zones-v2-1-8c2b89b4c9c5@radxa.com?part=1