Re: [PATCH v16 10/22] dt-bindings: media: i2c: max96712: add control-channel-port property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing schema constraint for variant-specific property `maxim,control-channel-port`
--

commit 1c245f50a34397eb74c873313431f23cd90654bf
Author: Dumitru Ceclan <dumitru.ceclan@analog.com>

dt-bindings: media: i2c: max96712: add control-channel-port property
    
Add maxim,control-channel-port property to allow platforms choose which
control-channel port MAX96724 exposes to the upstream I2C host.

> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> @@ -41,6 +41,15 @@ properties:
>  
>    enable-gpios: true
>  
> +  maxim,control-channel-port:
> +    description:
> +      Selects which deserializer control-channel port is connected to the
> +      upstream I2C segment when the device resets. 0 selects port 0, 1 selects
> +      port 1. Defaults to 0 when omitted.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1]
> +    default: 0
> +

[Severity: Low]
The commit message indicates this property is intended for the MAX96724 variant.
However, because it is added globally under the properties block, it will pass
validation for all devices matching this schema, including maxim,max96712.

Should this property be conditionally restricted in an allOf if/then block so
that invalid device trees for variants not supporting it fail schema validation?

>    i2c-alias-pool:
>      maxItems: 4

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-gmsl2-3_serdes-v16-0-4fa6e08bb514@analog.com?part=10