Re: [PATCH v3 2/2] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Compilation Error: Unresolved phandles `&devctrl` and `&pllctrl` in DT schema example.
--

commit 739cbb745f8880f754c15be8b7a4abc126a091dc
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema

Convert the Texas Instruments Keystone Device State Control binding from
legacy text format to DT schema. During the conversion, bus properties
were added and child nodes were documented.

> diff --git a/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml
> new file mode 100644
> index 0000000000000..dd73b62357cad
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    device-state-control@2620000 {
> +        compatible = "ti,keystone-devctrl", "syscon", "simple-mfd";
> +        reg = <0x02620000 0x1000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges = <0x0 0x02620000 0x1000>;
> +
> +        interrupt-controller@2a0 {
> +            compatible = "ti,keystone-irq";
> +            reg = <0x2a0 0x4>;
> +            interrupts = <GIC_SPI 4 IRQ_TYPE_EDGE_RISING>;
> +            interrupt-controller;
> +            #interrupt-cells = <1>;
> +            ti,syscon-dev = <&devctrl 0x2a0>;

[Severity: Low]
Does this reference to &devctrl cause a compilation error during
dt_binding_check? The devctrl label from the original text binding seems to
have been dropped from the parent device-state-control node above.

> +        };
> +
> +        reset-controller@328 {
> +            compatible = "ti,keystone-reset";
> +            reg = <0x328 0x10>;
> +            ti,syscon-pll = <&pllctrl 0xe4>;

[Severity: Low]
Will this reference to &pllctrl also trigger a build error? It looks like
the pllctrl label is completely missing from the example.

> +            ti,syscon-dev = <&devctrl 0x328>;
> +            ti,wdt-list = <0>;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-ti-keystone-devctrl-v3-0-0614fceba0f1@gmail.com?part=2