Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces an inconsistency by explicitly allowing the legacy fallback compatible string `dlg,da9053-aa` with `dlg,da9052`, but omitting `dlg,da9053` which uses the exact same pattern.
--

commit abd213140dc2339cb1dfe32c3ccb7bfd92c4ba9b
Author: Frank Li <Frank.Li@nxp.com>

dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052

This patch adds a fallback compatible string schema allowing dlg,da9053-aa to
fall back to dlg,da9052 in order to resolve a legacy platform check_dtbs
warning.

> diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
> index 1103a8cc5cea4..d1d23c7c4d0c2 100644
> --- a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
> +++ b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
> @@ -18,6 +18,10 @@ properties:
>            - dlg,da9053-bb
>            - dlg,da9053-bc
>            - dlg,da9052
> +      - items:
> +          - enum:
> +              - dlg,da9053-aa
> +          - const: dlg,da9052

[Severity: Low]
Does this fallback allowance also need to include the plain dlg,da9053 variant
to completely fix the warnings?

Looking at arch/arm/boot/dts/nxp/imx/imx53-smd.dts, the pmic node still
relies on the missing fallback pattern:

		compatible = "dlg,da9053", "dlg,da9052";

Without including dlg,da9053 in the enum alongside dlg,da9053-aa, won't
the legacy device tree node continue to generate a dtbs_check warning?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831201522.51294-1-Frank.Li@oss.nxp.com?part=1