Re: [PATCH v4 2/2] spi: dt-bindings: ti,davinci-spi: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema uses `const: ti,keystone-spi` within the `if` block checking the `compatible` property. Because `compatible` is parsed and evaluated as an array of strings by dt-schema, comparing it directly to a scalar string using `const` will always evaluate to false. This silently bypasses the schema constraint, allowing device tree nodes with `ti,keystone-spi` to pass validation even when they omit the required `power-domains` property (as demonstrated by the first example in the schema, which lacks `power-domains`). The correct match operator is `contains: const: ti,keystone-spi`.
--

commit 1f217c9462f9b9ccc473fed6ad4bc95248f60b00
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

spi: dt-bindings: ti,davinci-spi: Convert to DT schema

This commit converts the TI DaVinci/Keystone SPI controller binding
from text format to DT schema. It creates a separate peripheral schema
for the ti,spi-wdelay property and adds missing DMA properties.

> diff --git a/Documentation/devicetree/bindings/spi/ti,davinci-spi.yaml b/Documentation/devicetree/bindings/spi/ti,davinci-spi.yaml
> new file mode 100644
> index 0000000000000..672d03d2492b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/ti,davinci-spi.yaml

[ ... ]

> +allOf:
> +  - $ref: spi-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          const: ti,keystone-spi

[Severity: Medium]
Does this const check correctly evaluate the compatible property?

Since compatible is parsed and evaluated as an array of strings by
dt-schema, comparing it directly to a scalar string using const will
always silently evaluate to false. This bypasses the schema constraint
and allows device tree nodes with ti,keystone-spi to pass validation
even when they omit the required power-domains property.

Should this match against the array by using contains:
        compatible:
          contains:
            const: ti,keystone-spi
instead?

> +    then:
> +      required:
> +        - power-domains
> +
> +unevaluatedProperties: false

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-ti-davinci-spi-v4-0-92e9c0b2e1d4@gmail.com?part=2