Re: [PATCH v4 2/2] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YAML example block contains phandle references to labels that are not defined, causing `dt_binding_check` to fail compilation.
--

commit afa65fa8e16c9a7e5fce2efb40236086a0eed689
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema

Convert the Texas Instruments Keystone Device State Control binding from
legacy text format to DT schema.

> diff --git a/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml
> new file mode 100644
> index 0000000000000..564dfc8a731f2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    device-state-control@2620000 {

[Severity: Low]
Does omitting the devctrl: label from this node cause compilation to fail?

When make dt_binding_check is run, it extracts the examples block in
Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml into a
standalone .dts file and compiles it. Without the label, subsequent
references to &devctrl in the child nodes cannot be resolved by dtc.

> +        compatible = "ti,keystone-devctrl", "syscon", "simple-mfd";
> +        reg = <0x02620000 0x1000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges = <0x0 0x02620000 0x1000>;
> +
> +        interrupt-controller@2a0 {
> +            compatible = "ti,keystone-irq";
> +            reg = <0x2a0 0x4>;
> +            interrupts = <GIC_SPI 4 IRQ_TYPE_EDGE_RISING>;
> +            interrupt-controller;
> +            #interrupt-cells = <1>;
> +            ti,syscon-dev = <&devctrl 0x2a0>;

[Severity: Low]
Can this use the &devctrl phandle since the label wasn't defined on the
parent node?

> +        };
> +
> +        reset-controller@328 {
> +            compatible = "ti,keystone-reset";
> +            reg = <0x328 0x10>;
> +            ti,syscon-pll = <&pllctrl 0xe4>;

[Severity: Low]
Is the &pllctrl phandle defined anywhere in this example?

Because the examples block is compiled independently during dt_binding_check,
referencing an undefined &pllctrl phandle will cause dtc compilation to fail.
A dummy pllctrl node might be required here.

> +            ti,syscon-dev = <&devctrl 0x328>;
> +            ti,wdt-list = <0>;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-ti-keystone-devctrl-v4-0-2922f2a44792@gmail.com?part=2