From: Luca Weiss <luca.weiss@fairphone.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Luca Weiss <luca.weiss@fairphone.com>
Subject: [PATCH 2/4] regulator: qcom-rpmh: Add supply names for PM6350
Date: Tue, 01 Sep 2026 10:58:57 +0200 [thread overview]
Message-ID: <20260901-fp4-regulator-supply-v1-2-68288ab70aee@fairphone.com> (raw)
In-Reply-To: <20260901-fp4-regulator-supply-v1-0-68288ab70aee@fairphone.com>
The supply names for the PM6350 regulators were skipped during initial
bringup. Add them.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
drivers/regulator/qcom-rpmh-regulator.c | 46 ++++++++++++++++-----------------
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
index 25c14de3cd8b..dd2265961151 100644
--- a/drivers/regulator/qcom-rpmh-regulator.c
+++ b/drivers/regulator/qcom-rpmh-regulator.c
@@ -1589,31 +1589,31 @@ static const struct rpmh_vreg_init_data pm6150l_vreg_data[] = {
};
static const struct rpmh_vreg_init_data pm6350_vreg_data[] = {
- RPMH_VREG("smps1", SMPS, 1, &pmic5_ftsmps510, NULL),
- RPMH_VREG("smps2", SMPS, 2, &pmic5_hfsmps510, NULL),
+ RPMH_VREG("smps1", SMPS, 1, &pmic5_ftsmps510, "vdd-s1"),
+ RPMH_VREG("smps2", SMPS, 2, &pmic5_hfsmps510, "vdd-s2"),
/* smps3 - smps5 not configured */
- RPMH_VREG("ldo1", LDO, 1, &pmic5_nldo, NULL),
- RPMH_VREG("ldo2", LDO, 2, &pmic5_pldo, NULL),
- RPMH_VREG("ldo3", LDO, 3, &pmic5_pldo, NULL),
- RPMH_VREG("ldo4", LDO, 4, &pmic5_nldo, NULL),
- RPMH_VREG("ldo5", LDO, 5, &pmic5_pldo, NULL),
- RPMH_VREG("ldo6", LDO, 6, &pmic5_pldo, NULL),
- RPMH_VREG("ldo7", LDO, 7, &pmic5_pldo, NULL),
- RPMH_VREG("ldo8", LDO, 8, &pmic5_pldo, NULL),
- RPMH_VREG("ldo9", LDO, 9, &pmic5_pldo, NULL),
- RPMH_VREG("ldo10", LDO, 10, &pmic5_pldo, NULL),
- RPMH_VREG("ldo11", LDO, 11, &pmic5_pldo, NULL),
- RPMH_VREG("ldo12", LDO, 12, &pmic5_pldo, NULL),
- RPMH_VREG("ldo13", LDO, 13, &pmic5_nldo, NULL),
- RPMH_VREG("ldo14", LDO, 14, &pmic5_pldo, NULL),
- RPMH_VREG("ldo15", LDO, 15, &pmic5_nldo, NULL),
- RPMH_VREG("ldo16", LDO, 16, &pmic5_nldo, NULL),
+ RPMH_VREG("ldo1", LDO, 1, &pmic5_nldo, "vdd-l1"),
+ RPMH_VREG("ldo2", LDO, 2, &pmic5_pldo, "vdd-l2-l5-l7"),
+ RPMH_VREG("ldo3", LDO, 3, &pmic5_pldo, "vdd-l3-l6-l8-l9-l10"),
+ RPMH_VREG("ldo4", LDO, 4, &pmic5_nldo, "vdd-l4"),
+ RPMH_VREG("ldo5", LDO, 5, &pmic5_pldo, "vdd-l2-l5-l7"),
+ RPMH_VREG("ldo6", LDO, 6, &pmic5_pldo, "vdd-l3-l6-l8-l9-l10"),
+ RPMH_VREG("ldo7", LDO, 7, &pmic5_pldo, "vdd-l2-l5-l7"),
+ RPMH_VREG("ldo8", LDO, 8, &pmic5_pldo, "vdd-l3-l6-l8-l9-l10"),
+ RPMH_VREG("ldo9", LDO, 9, &pmic5_pldo, "vdd-l3-l6-l8-l9-l10"),
+ RPMH_VREG("ldo10", LDO, 10, &pmic5_pldo, "vdd-l3-l6-l8-l9-l10"),
+ RPMH_VREG("ldo11", LDO, 11, &pmic5_pldo, "vdd-l11"),
+ RPMH_VREG("ldo12", LDO, 12, &pmic5_pldo, "vdd-l12-l14"),
+ RPMH_VREG("ldo13", LDO, 13, &pmic5_nldo, "vdd-l13"),
+ RPMH_VREG("ldo14", LDO, 14, &pmic5_pldo, "vdd-l12-l14"),
+ RPMH_VREG("ldo15", LDO, 15, &pmic5_nldo, "vdd-l15-l19-l22"),
+ RPMH_VREG("ldo16", LDO, 16, &pmic5_nldo, "vdd-l16"),
/* ldo17 not configured */
- RPMH_VREG("ldo18", LDO, 18, &pmic5_nldo, NULL),
- RPMH_VREG("ldo19", LDO, 19, &pmic5_nldo, NULL),
- RPMH_VREG("ldo20", LDO, 20, &pmic5_nldo, NULL),
- RPMH_VREG("ldo21", LDO, 21, &pmic5_nldo, NULL),
- RPMH_VREG("ldo22", LDO, 22, &pmic5_nldo, NULL),
+ RPMH_VREG("ldo18", LDO, 18, &pmic5_nldo, "vdd-l18-l20-l21"),
+ RPMH_VREG("ldo19", LDO, 19, &pmic5_nldo, "vdd-l15-l19-l22"),
+ RPMH_VREG("ldo20", LDO, 20, &pmic5_nldo, "vdd-l18-l20-l21"),
+ RPMH_VREG("ldo21", LDO, 21, &pmic5_nldo, "vdd-l18-l20-l21"),
+ RPMH_VREG("ldo22", LDO, 22, &pmic5_nldo, "vdd-l15-l19-l22"),
};
static const struct rpmh_vreg_init_data pmcx0102_vreg_data[] = {
--
2.55.0
next prev parent reply other threads:[~2026-09-01 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 8:58 [PATCH 0/4] Add supply names for PM6350 RPMh regulators on Fairphone 4 Luca Weiss
2026-09-01 8:58 ` [PATCH 1/4] regulator: dt-bindings: qcom,rpmh: Add supply names for PM6350 Luca Weiss
2026-09-03 11:31 ` Krzysztof Kozlowski
2026-09-01 8:58 ` Luca Weiss [this message]
2026-09-02 9:01 ` [PATCH 2/4] regulator: qcom-rpmh: " Abel Vesa
2026-09-01 8:58 ` [PATCH 3/4] regulator: qcom-rpmh: Add missing regulators in PM6350 Luca Weiss
2026-09-02 8:51 ` Konrad Dybcio
2026-09-02 9:01 ` Abel Vesa
2026-09-01 8:58 ` [PATCH 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add parent supply for regulators Luca Weiss
2026-09-02 8:53 ` Konrad Dybcio
2026-09-03 15:01 ` Bjorn Andersson
2026-09-04 18:45 ` (subset) [PATCH 0/4] Add supply names for PM6350 RPMh regulators on Fairphone 4 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901-fp4-regulator-supply-v1-2-68288ab70aee@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox