From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51382480DC4; Tue, 1 Sep 2026 15:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788277185; cv=none; b=JSNvWbzr3QdTpgSxCA5OGlu16QRfdvjSl/mSZ9GN7j39eTLGgAgkpmREqdm5N0fHtAWcgoJ1pNK8cxnNQTQwyF5jQ1Ivb9Bfar1jtwZDG4YEtOoFZb8zYko4Yrq+qFxZ/dB1QyY3U/D/TARzwZQ0ETsSxRIDUBpUoWLkschU1Tc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788277185; c=relaxed/simple; bh=hDLmPmzyXSsHzKx7g4NI8YUWs5fKSEiY9RsT5ITJWfo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p9hUEs+WbhkUwOGoiKdTEfdzzARclTjg2bEHI4vPSgv4aYnJade3NUtKk2WxYfhyHsYm6gfgfMg8iTyM27ISsQBrP/Giw1oYWpWhnkj5lDjtzXfeJWkXOgdOz/dlYqjjmgTJ6YgjJ2vxdxPwiERFGMe9lxdExNVGmTU07tRnB3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=MSwMYSQc; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="MSwMYSQc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1788277181; bh=hDLmPmzyXSsHzKx7g4NI8YUWs5fKSEiY9RsT5ITJWfo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MSwMYSQcIZNhgdDIx9HJmMd4iuZsI5W+ABSyKMRH2pxO7uyyGA9ictaxGnLYNCc9e LcHPIB9kzHUeGRsAj9p2cAXVYGpvs0EypFq+D9eP1q5iipxfEqx7FGe3RJW9h4jP4P 0YxMwV/1qpBfKwGLV97M1AyADpDEkh+yaCSeb0uIai2eCxA53w4bRRE4zDoWbI9UUS vVzdxi9aTGy7ZNVbYnSrPZF0e2qvVIxgyY4CP4+HfRbQ1PJQ4ngpQC4jYUIGwDRQBl 7YnFK+/Zxe25CETajFovTHE2gFGtp1AvMrjhJ1frrDHYCCW/DMnsxDrXG6dDX2v6Li XJF5SYQVHJz8w== Received: from yukiji.home (unknown [100.64.0.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7A01A17E0934; Tue, 01 Sep 2026 17:39:40 +0200 (CEST) From: Louis-Alexis Eyraud Date: Tue, 01 Sep 2026 17:39:03 +0200 Subject: [PATCH v11 15/24] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260901-mt8196-ufs-v11-15-dbd007704490@collabora.com> References: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> In-Reply-To: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> To: Chunfeng Yun , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Peter Wang , Chaotian Jing , Alim Akhtar , Avri Altman , Bart Van Assche , Stanley Jhu , "James E.J. Bottomley" , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , "Martin K. Petersen" , "Martin K. Petersen" Cc: kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nicolas Frattaroli , Louis-Alexis Eyraud X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788277163; l=2134; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=JMEyQZm9mztqyjWLzyrw20bJKmXDPQGwgKTDP2yACkw=; b=IY3OPhC4PuVuRaRLm6DQ9S7nhW6avTtuGHIUl51Vv9m6GKBtxCO29J3RkUD9qUqDv6HdkSu2A smr4QlcZvjbBZ1Hkbq2IuQUBuVrRrbh1nc1kGtfKBYrwx3ZBgHsWjiE X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= From: Nicolas Frattaroli This flag property was never described in the binding, and its capability wrapper seems pointless. If one of the MediaTek SoCs needs the ufshcd quirk applied, then this can be done per-compatible, without needing to give the device tree author the option to forget to set it. Remove it and the associated capability flag wrapping code. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Peter Wang Signed-off-by: Nicolas Frattaroli Signed-off-by: Louis-Alexis Eyraud --- drivers/ufs/host/ufs-mediatek.c | 5 ----- drivers/ufs/host/ufs-mediatek.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 1df16ce29ea4..5d8c02b7a857 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -684,9 +684,6 @@ static void ufs_mtk_init_host_caps(struct ufs_hba *hba) if (of_property_read_bool(np, "mediatek,ufs-rtff-mtcmos")) host->caps |= UFS_MTK_CAP_RTFF_MTCMOS; - if (of_property_read_bool(np, "mediatek,ufs-broken-rtc")) - host->caps |= UFS_MTK_CAP_MCQ_BROKEN_RTC; - dev_info(hba->dev, "caps: 0x%x", host->caps); } @@ -1225,8 +1222,6 @@ static int ufs_mtk_init(struct ufs_hba *hba) hba->quirks |= UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL; hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_INTR; - if (host->caps & UFS_MTK_CAP_MCQ_BROKEN_RTC) - hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_RTC; hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80); diff --git a/drivers/ufs/host/ufs-mediatek.h b/drivers/ufs/host/ufs-mediatek.h index bde2b53f5798..d97951ee1f4e 100644 --- a/drivers/ufs/host/ufs-mediatek.h +++ b/drivers/ufs/host/ufs-mediatek.h @@ -138,8 +138,6 @@ enum ufs_mtk_host_caps { UFS_MTK_CAP_DISABLE_MCQ = 1 << 8, /* Control MTCMOS with RTFF */ UFS_MTK_CAP_RTFF_MTCMOS = 1 << 9, - - UFS_MTK_CAP_MCQ_BROKEN_RTC = 1 << 10, }; struct ufs_mtk_crypt_cfg { -- 2.55.0