Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Marek Vasut <marex@nabladev.com>
Cc: linux-pm@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Flaviu Nistor <flaviu.nistor@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings
Date: Tue, 1 Sep 2026 19:03:02 +0100	[thread overview]
Message-ID: <20260901-stammer-outward-dde753ce2c32@spud> (raw)
In-Reply-To: <20260901174847.97261-1-marex@nabladev.com>

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

On Tue, Sep 01, 2026 at 07:47:54PM +0200, Marek Vasut wrote:
> The TMP102 and TMP110 are backward compatible, therefore the valid
> compatible strings are "ti,tmp110", "ti,tmp102" and "ti,tmp102" .
> 
> The TMP103 is not backward compatible with TMP102, but it does share a
> schema now, therefore the only valid compatible string for the TMP103
> should be "ti,tmp103" .
> 
> Make exactly those three compatible strings valid and everything else
> rejected.
> 
> Fixes: d67ec24d3f07 ("dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml")
> Signed-off-by: Marek Vasut <marex@nabladev.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
(I am just realising now that the reason for this was the binding
in-tree having been cocked up)

> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Flaviu Nistor <flaviu.nistor@gmail.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-hwmon@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> V3: New patch
> ---
>  Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> index 55d9f106465d7..477f478b9dd0f 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -13,11 +13,10 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> -          - const: ti,tmp102
> -          - const: ti,tmp103
>            - const: ti,tmp110
> -      - enum:
> -          - ti,tmp102
> +          - const: ti,tmp102
> +      - const: ti,tmp102
> +      - const: ti,tmp103
>  
>    interrupts:
>      maxItems: 1
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2026-09-01 18:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 17:47 [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings Marek Vasut
2026-09-01 17:47 ` [PATCH v3 2/2] dt-bindings: hwmon: tmp102: Document TMP113 Marek Vasut
2026-09-01 17:53   ` sashiko-bot
2026-09-01 18:03   ` Conor Dooley
2026-09-01 18:20   ` Guenter Roeck
2026-09-01 17:53 ` [PATCH v3 1/2] dt-bindings: hwmon: tmp102: Fix up TMP103 bindings sashiko-bot
2026-09-01 18:03 ` Conor Dooley [this message]
2026-09-01 18:17 ` Guenter Roeck
2026-09-01 18:30   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901-stammer-outward-dde753ce2c32@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=flaviu.nistor@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marex@nabladev.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox