From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9161C39A06F for ; Tue, 1 Sep 2026 01:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788225232; cv=none; b=Nz0q2FmdDwAbP22ydKHZxFiVpyEivGmur4Qi87z3DlTwQcIu6EPVB+rL1cP6cYeqGWp13OCLyOvKYvpb/3mZfQ9Yi2HqY0G7ZPKLBMqo5jF+ad6pS1WBBTv+KQ6buw4eoPzLCTcQMmbq0Kyud/12gF+25tVJWWTAplSJVW/PMw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788225232; c=relaxed/simple; bh=WKNiEu5bb54kPNb9BHttsHup3tUYWbXtGShP7J3NSTI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DI42OHEYxaHPwYz0oO7ikkrTxka+iki8wIp5j3pd0PTuj5OHPT+ThEksvjdoYx8kP2HirY1t66ZeQWoilJBR6yAVZ/SLldWxpz4oUq5yslSCzJO1bm7nb/Wqbsoe3fmDMI32+T97Pz44MB3fsVLYUWMO2cG34CFgeQ/6TmIEyA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=LUkh9QB1; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="LUkh9QB1" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-930f618435cso362704485a.3 for ; Mon, 31 Aug 2026 18:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1788225228; x=1788830028; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3KMFnK7MaewcQgkI6RfHvTFLlVRVgXCbhr3VFJt6MAI=; b=LUkh9QB1qbS5Ebdef1hnPz1YpFe912bhC/nANz2FQNEbW36eEEKyImMKVyf15go/IE LR0EO+1Dxf1/Bu+UIoyXk77Dp0aNsi40PHAbMC7uIM+bV5K1fjvAGCGGrDY2WSiwb2Cz t44RfbAk9QrwviAtzEmLVXJ7+bt+lGOuyleDY5asm4B+iW31N+3YlQ+nKLCKRYecCMJL yAC6jl/qCqenleubmFXnTXipi8J/QKLDcckwyC/eO9YxRMiSyec6JZxThWa9guzJYdzn Q4yjj3Y4HMX0HF5kC8JAAtB7gEN1/b6+cjjTlrZkHOlS+yfTXDMMp+o2S8EPA5go4gNL fAGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788225228; x=1788830028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3KMFnK7MaewcQgkI6RfHvTFLlVRVgXCbhr3VFJt6MAI=; b=WNXSf47Fn+/S+1hOTPlPEnkp/ep1bCtSHZIvP6zuBbb4r/bZLt3dRyC9t2tVRH34tJ Sch4oZrDEC9BsMZ/BCVIFD8tiFX0Epy0A2E64CoMFcw5cStjDcA9JWeMdoqLEwvbP4JC vazk2DfkMkjXGdmpZ6+6JHQQk7ftcl3QZjMMpS/ZjjLOPasg4sUoueEF2JMH29Ljj0kG fL9YPkZ3epoIM0vTGyXdmQdW+r521wIoAN89tiQMbczMcENu6a0Rkh8GegsNRHs5N9TM tOlN+Bc7NPc10cDmq/z7nf6YNR5g/Hgq4x71F8DAC6wAyuTq3Gjbx/80Gp0kXk6uVz5W Fvhg== X-Forwarded-Encrypted: i=1; AHgh+RrxtYFCfYkPt3reQuYiiArELJPVdv3Sw9X1QhM949zenYGvxZE/qv/r0RogUN0PZafgvYd6cOX8R1oi@vger.kernel.org X-Gm-Message-State: AFuF++npwDiTl98Ilaed+7T7YcaFfzB8D5D174hxlm//nD17ZzgFj/bK 66rCaeQ2tnEHTGC8p9acGsXySmhIhs9CUgKQS8NDjHLW1YPA0QKvK0g9K9FIlRIedfg= X-Gm-Gg: AR+sD13Lx1lcMJoApD0kKUv2csH5GgZrOMq/S7F4TMmoVKPIjTXI+nhNk8xceZB9sN7 3FfG9EDJVp8w/CiqVawHd8v9tU9Mz4jk8hWhDYqVl5Z+twCnX22OXT582q//ReBYUsr5wAg3ol5 Xecks7zz78qzgaQGS1gi+XpHFIBxBGCciyjUwbGkQOmXqdRlMX9PgG813eHMBZyxI9YKD5uBUHp /grDGdIfJ72jNrHVWcwnEszHYwLUjG/0D1y6UZi2tLuTsByzj100cOdxz3D5weKzDE8qjFbfJNo E2ywjE2Nh36RgZ9xxVIssRrwisE/cCFzeJF3EHuaJA1XvHt4wuh4ptcCf0qgEIL8zZhLE8totWU H2NZD9cjRziyXJxJ3aNeKURMJV6iLjz9A6FFkJkkUeQ5TQuSeKKCnDRMyIaVs2zD2MiU22jR4IX kvtmADnWIbgQ9d5AMh6BPJCPwi1s3vUDiYwRTyMaYoQ5J8/uADqMErQaqe1uBPLtUWF0ArZFiMJ S4= X-Received: by 2002:a05:620a:40cb:b0:930:b4f9:f327 with SMTP id af79cd13be357-939138df3d1mr3066774785a.33.1788225228344; Mon, 31 Aug 2026 18:13:48 -0700 (PDT) Received: from zippy.localdomain ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9391740a307sm581347285a.42.2026.08.31.18.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2026 18:13:47 -0700 (PDT) From: Alex Elder To: bhelgaas@google.com, robh@kernel.org, saravanak@kernel.org Cc: herve.codina@bootlin.com, daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/4] of: address: kill of_node_is_pcie() Date: Mon, 31 Aug 2026 20:13:37 -0500 Message-ID: <20260901011338.1323243-5-elder@riscstar.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260901011338.1323243-1-elder@riscstar.com> References: <20260901011338.1323243-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The of_bus->match function for the "PCI" bus type is fairly liberal in what it accepts as a PCI bus devicetree node. If a node has no device_type property, it even allows a node named "pcie@" to be accepted as represnting a devicetree bus, though it issues a warning in that case. A recent PCI commit introduced of_pci_verify_node(). When a PCI device is added, if it has a devicetree node, that function checks its device_type property. For PCI bridge devices, if there is no device_type property (value "pci"), a warning is issued. That warning duplicates the warning made by of_node_is_pcie(), and there's no point in that. Avoid the second (OF) warning by just checking the node name directly in of_bus_pci_match(). That leaves of_node_is_pcie() unused, so get rid of it. Signed-off-by: Alex Elder --- v3: - Added (new) in this version of the series drivers/of/address.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index 499d37ceae210..ee2eb44884d85 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -134,16 +134,6 @@ static unsigned int of_bus_pci_get_flags(const __be32 *addr) * PCI bus specific translator */ -static bool of_node_is_pcie(const struct device_node *np) -{ - bool is_pcie = of_node_name_eq(np, "pcie"); - - if (is_pcie) - pr_warn_once("%pOF: Missing device_type\n", np); - - return is_pcie; -} - static int of_bus_pci_match(struct device_node *np) { /* @@ -156,7 +146,7 @@ static int of_bus_pci_match(struct device_node *np) */ return of_node_is_type(np, "pci") || of_node_is_type(np, "pciex") || of_node_is_type(np, "vci") || of_node_is_type(np, "ht") || - of_node_is_pcie(np); + of_node_name_eq(np, "pcie"); } static void of_bus_pci_count_cells(struct device_node *np, -- 2.53.0