From: sashiko-bot@kernel.org
To: "Wenmeng Liu" <wenmeng.liu@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH RESEND v3 1/2] dt-bindings: media: i2c: Add Samsung S5KJN5 image sensor
Date: Tue, 01 Sep 2026 08:03:25 +0000 [thread overview]
Message-ID: <20260901080325.7A22A1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260901-sk5jn5-v3-1-17e728917bd4@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mandatory power supplies are omitted from the 'required' list.
--
commit b2a07d6873604e9daaa63bfab639ae1468786baf
Author: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
dt-bindings: media: i2c: Add Samsung S5KJN5 image sensor
This commit adds the device tree binding schema for the Samsung S5KJN5, a
50MP 10-bit RAW MIPI CSI-2 image sensor controlled via I2C.
> diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml
> new file mode 100644
> index 0000000000000..fedb274679cd1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml
[ ... ]
> + required:
> + - link-frequencies
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - port
[Severity: Medium]
Should the mandatory power supplies be explicitly included in this required
list?
The properties block earlier in the schema defines vddio-supply, vdda-supply,
vddm-supply, and vddd-supply. By omitting them from the required list,
dt_binding_check will incorrectly pass device tree nodes that miss these
physically required hardware power supplies. This allows incomplete hardware
descriptions to be accepted, which can cause the driver to fail during probe
or rely on dummy regulators, thereby breaking proper power management.
> +
> +unevaluatedProperties: false
> +
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-sk5jn5-v3-0-17e728917bd4@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-01 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 7:53 [PATCH RESEND v3 0/2] media: i2c: Add Samsung S5KJN5 image sensor Wenmeng Liu
2026-09-01 7:53 ` [PATCH RESEND v3 1/2] dt-bindings: " Wenmeng Liu
2026-09-01 8:03 ` sashiko-bot [this message]
2026-09-01 7:53 ` [PATCH RESEND v3 2/2] media: i2c: Add Samsung S5KJN5 image sensor driver Wenmeng Liu
2026-09-01 8:06 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901080325.7A22A1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox