From: sashiko-bot@kernel.org
To: "Xin Liu" <xin.liu@oss.qualcomm.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v3 1/2] arm64: dts: qcom: hamoa: Add PSCI SYSTEM_RESET2 types
Date: Tue, 01 Sep 2026 08:04:51 +0000 [thread overview]
Message-ID: <20260901080452.5A6ED1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260901075552.3558150-2-xin.liu@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The addition of the `reboot-mode` subnode to the `psci` node violates the PSCI device tree binding schema, causing `make dtbs_check` to fail.
--
commit 0761e0e4725677d66ad02781f96c6323f5504b5a
Author: Xin Liu <xin.liu@oss.qualcomm.com>
arm64: dts: qcom: hamoa: Add PSCI SYSTEM_RESET2 types
This commit adds support for SYSTEM_RESET2 vendor-specific resets as
reboot-modes in the psci node. It defines "bootloader" and "edl" reset
modes for the hamoa-iot-evk device.
> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> index 9fa86bb6438ec..5db2f19dc86c3 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> @@ -1192,6 +1192,13 @@ &pmk8550_pwm {
> status = "okay";
> };
>
> +&psci {
> + reboot-mode {
> + mode-bootloader = <0x80010001 0x2>;
> + mode-edl = <0x80000000 0x1>;
> + };
> +};
[Severity: Low]
Does adding the reboot-mode subnode to the psci node violate the PSCI device
tree binding schema?
The psci schema in Documentation/devicetree/bindings/arm/psci.yaml specifies
additionalProperties: false and does not define or reference a reboot-mode
property.
Will adding this undocumented subnode cause a dtbs_check validation failure
during the build?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260901075552.3558150-1-xin.liu@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-01 8:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 7:55 [PATCH v3 0/2] Add psci_sys_reset2 reboot modes for hamoa and purwa boards Xin Liu
2026-09-01 7:55 ` [PATCH v3 1/2] arm64: dts: qcom: hamoa: Add PSCI SYSTEM_RESET2 types Xin Liu
2026-09-01 8:04 ` sashiko-bot [this message]
2026-09-01 7:55 ` [PATCH v3 2/2] arm64: dts: qcom: purwa: " Xin Liu
2026-09-01 8:10 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901080452.5A6ED1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xin.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox