Re: [PATCH v7 02/11] ARM: dts: aspeed: anacapa: Add EVT2 devicetree inheriting EVT1

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect GPIO line name mapping due to a likely copy-paste error in the B-block of sgpiom0.
--

commit aa80bc774dd824dd074a3ccff2eaf0de685d5eb4
Author: Colin Huang <u8813345@gmail.com>

ARM: dts: aspeed: anacapa: Add EVT2 devicetree inheriting EVT1

This commit adds a development-phase devicetree for the Facebook Anacapa BMC
EVT2 hardware revision. It updates the Anacapa wrapper DTS to reference this
new EVT2 file instead of EVT1.

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dtsi b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dtsi
> new file mode 100644
> index 0000000000000..be7f17ad5f8ec
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dtsi
> @@ -0,0 +1,168 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +
> +/dts-v1/;
> +#include "aspeed-bmc-facebook-anacapa-evt1.dtsi"
> +
> +&sgpiom0 {
> +	gpio-line-names =

[ ... ]

> +	/* B0-B7 line 16-31 */
> +	"Channel0_leakage_EAM3", "FM_CPU_FPGA_JTAG_MUX_SEL",
> +	"Channel1_leakage_EAM0", "FM_SCM_JTAG_MUX_SEL",
> +	"Channel2_leakage_Manifold1", "FM_BRIDGE_JTAG_MUX_SEL",
> +	"Channel5_leakage_present_EAM1", "FM_CPU0_NMI_SYNC_FLOOD_N",

[Severity: Medium]
Does this code break the sequence of ChannelX_leakage pins?

It places a _present signal here instead of in the D or C blocks, which
strongly suggests a copy-paste error overwriting what should have been
Channel3_leakage.

If this is an unintended copy-paste error in the B-block of sgpiom0,
userspace tools monitoring hardware could read the wrong physical pin for
Channel 5's presence and fail to read Channel 3's leakage entirely,
breaking hardware monitoring logic.

> +	"Channel4_leakage_Manifold2", "BMC_AINIC0_WP_R2_L",
> +	"Channel5_leakage_EAM1", "BMC_AINIC1_WP_R2_L",
> +	"Channel6_leakage_CPU_DIMM", "CPLD_BUF_R_AGPIO330",
> +	"Channel7_leakage_EAM2", "CPLD_BUF_R_AGPIO331",

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-anacapa-devlop-phase-devicetree-v7-0-0bd71d2e0105@gmail.com?part=2