From: Rob Herring <robh@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: sashiko-reviews@lists.linux.dev, linux-pci@vger.kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/4] PCI: of: introduce of_pci_verify_node()
Date: Tue, 1 Sep 2026 12:32:39 -0500 [thread overview]
Message-ID: <20260901173239.GD1244140-robh@kernel.org> (raw)
In-Reply-To: <cde3da8f-933a-41ef-b7b8-f78317ca2d67@riscstar.com>
On Mon, Aug 31, 2026 at 09:42:46PM -0500, Alex Elder wrote:
> On 8/31/26 8:21 PM, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Medium] The check in of_pci_verify_node() falsely flags compliant CardBus and PowerPC PCIe bridges as having an invalid device_type.
>
> I was unfortunately not considering those types of bridges,
> and don't have experience with (or access to) either.
>
> In the devicetree code, of_bus_pci_match() does check for
> device_type "pciex" but does not handle "cardbus" (at least,
> not explicitly--the "default-flags" bus type might do the
> right thing).
>
> I would love to get some pointers from others on how to
> do this correctly, but in any case I'll do a little more
> research on this before I post version 4.
I'm willing to wait and see if anyone cares about cardbus. I doubt it.
Maybe there's some old PowerBooks with cardbus?
"pciex" should probably be handled.
Rob
next prev parent reply other threads:[~2026-09-01 17:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 1:13 [PATCH v3 0/4] PCI: of: warn on bogus device_type property Alex Elder
2026-09-01 1:13 ` [PATCH v3 1/4] PCI: of: drop the reg_num argument to of_pci_set_address() Alex Elder
2026-09-01 1:16 ` sashiko-bot
2026-09-01 1:13 ` [PATCH v3 2/4] PCI: of: don't zero flags in of_pci_get_addr_flags() Alex Elder
2026-09-01 1:20 ` sashiko-bot
2026-09-01 2:42 ` Alex Elder
2026-09-01 1:13 ` [PATCH v3 3/4] PCI: of: introduce of_pci_verify_node() Alex Elder
2026-09-01 1:21 ` sashiko-bot
2026-09-01 2:42 ` Alex Elder
2026-09-01 17:32 ` Rob Herring [this message]
2026-09-02 12:54 ` Alex Elder
2026-09-01 6:11 ` Herve Codina
2026-09-01 1:13 ` [PATCH v3 4/4] of: address: kill of_node_is_pcie() Alex Elder
2026-09-01 1:18 ` sashiko-bot
2026-09-01 2:03 ` Alex Elder
2026-09-01 6:45 ` Herve Codina
2026-09-01 14:58 ` Alex Elder
2026-09-01 15:15 ` Herve Codina
2026-09-01 15:25 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901173239.GD1244140-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@riscstar.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox