From: sashiko-bot@kernel.org
To: "Robert Nelson" <robertcnelson@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: omap: Add BeagleBone Black RevD
Date: Tue, 01 Sep 2026 21:51:44 +0000 [thread overview]
Message-ID: <20260901215144.8B78F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260901-v7-3-rc1-beaglebone-black-revd-v1-1-f521950b777a@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new `beagle,am335x-bone-black-revd` compatible string is placed in a 2-item constraint block, structurally preventing the use of standard BeagleBone fallback strings.
--
commit 17e0af4d26654f2aa0193ef1f9c56643b10d76e4
Author: Robert Nelson <robertcnelson@gmail.com>
dt-bindings: omap: Add BeagleBone Black RevD
This commit adds the compatible string for the BeagleBone Black RevD to
the TI OMAP device tree binding schema.
> diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> @@ -104,6 +104,7 @@ properties:
> - description: TI AM33 based platform
> items:
> - enum:
> + - beagle,am335x-bone-black-revd
[Severity: Medium]
Does placing this compatible string in this specific block prevent the use
of standard BeagleBone fallback strings?
Because this block under properties.compatible.oneOf is configured for exactly
two items, it restricts the compatible property to just this new string and
ti,am33xx. This structurally prohibits including standard BeagleBone fallback
strings, such as ti,am335x-bone-black and ti,am335x-bone.
Attempting to define a standard 3-item or 4-item compatible string hierarchy
for the RevD board in the device tree might fail dt_binding_check. Could this
cause ecosystem interoperability issues if it forces the omission of fallbacks
needed for U-Boot quirks and userspace board identification?
> - compulab,cm-t335
> - moxa,uc-8100-me-t
> - novatech,am335x-lxm
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-v7-3-rc1-beaglebone-black-revd-v1-0-f521950b777a@gmail.com?part=1
next prev parent reply other threads:[~2026-09-01 21:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 21:42 [PATCH 0/3] Add support for BeagleBone Black RevD Robert Nelson
2026-09-01 21:42 ` [PATCH 1/3] dt-bindings: omap: Add " Robert Nelson
2026-09-01 21:51 ` sashiko-bot [this message]
2026-09-02 18:05 ` Conor Dooley
2026-09-01 21:42 ` [PATCH 2/3] arm: dts: omap: Add support for " Robert Nelson
2026-09-01 21:56 ` sashiko-bot
2026-09-01 21:42 ` [PATCH 3/3] arm: dts: ti: Enable overlays " Robert Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901215144.8B78F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox