From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CC5A4A8FF4 for ; Wed, 2 Sep 2026 19:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788376050; cv=none; b=YVtTc40rVYjLKvC4bs7vsosqdrnwNN+NmuRYiQAtcq6a+5q1dnwc9+LG5m4BLEyX1IEMlT3lGSMEPaoh6A6Q8hNigAtzc77fTN/6gZFcLwutjQ05YZyyElsLGFU+dEefyCUPmQfPiUVkK+b5B07Vstz/9mjvqM2v+sIvjWKP3Qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788376050; c=relaxed/simple; bh=/GqE7tbYa2dWg0FxwYbCrxOWd45I2GVxpnOL6juTks4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=PHC61ll3xssztCq4wCcN4QaxPgNRs17b9DF6jIuSaCXyge9g7mMVHhExfnfdvvJnROHap8qydGAIM7cmsLeswq7KYNFOm81nO0H/AdRoUjJ4trCWPpBvdFRDsre1ax0CvRepMepZtxLoD0/8D9AcaiGr/2EJL7NiuJ5yuERNnGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G7ifNw4F; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G7ifNw4F" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-48444ec4fe2so797618f8f.0 for ; Wed, 02 Sep 2026 12:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788376047; x=1788980847; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=zwE2z/0B3pciqCcOK64iCEKBwjRy6GchQ2Bx4KSJSo8=; b=G7ifNw4FFa7dTgAGk8gfSlNcC+9QOPIoUvLBs2fu4cpOcDHQ69KI93kKDLzOUh/q1I ujN2HLAsEYQ3B+EtQDHC4gQBi9igQuF1Po8skDnt3w4TbbVImQBSd0+TzW35xy/uRumq mYiucOndnlTHN9k1A98z6lFk+/66VrgE3fUSDRxbToJY3IC5NatIosr8AitCc/cFbHeP gPfGVSo6XMX9+SDEuIRxuHaasVvrq+5+/JEH39KGA3oh8S8Iu8XRS00kKSWBd9jjwi2R 6jVjbOI+dsrfumese3ktC8IotjLt5St4lFPk7A51b7FMQc4dIjM9Mnz0VmdX0HO2qiS1 wOPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788376047; x=1788980847; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=zwE2z/0B3pciqCcOK64iCEKBwjRy6GchQ2Bx4KSJSo8=; b=kcctmfz53M0eYs/e6K/UTml4MAKb5CE9IYeWv23cqDFsUeF1VI2U4FBRxL6ijbFwMg Ai2Wr+m6wNeRPyPM0DpcTZFBsCmTXAv8+r0AZV+p/gHAClJbox/hPzbdSDAv3NVdOP4N ELfn9DeYCLnws+uDmleg5p5u0Pow4P5YXJFSu6CIsvk+tuvwBY6U6Z+T/VpJ9TsKa7k2 8mN26A2Q9j1i0O8S1yZLZCzjciCvXkhBvM4LQZLfbT5Ni11TvV62nKNAAwcX8mGe5a+N VcCMEkokhedKHO/2lzdO75GzOX1J28QG2/QuW8xrmo3YZfdAYl3TeuOLGDRDhMzG8CbX D62A== X-Forwarded-Encrypted: i=1; AKwUvByEL6QqSmuw2Iz/AtKPiN3B9PcgUZfwdRXEgeB2ZDVps2sot/Yh+KKqgK9rrGmKEuukJ9mZGXz/jIqw@vger.kernel.org X-Gm-Message-State: AFuF++kb0iGOEMe2sNDtbI58yg4PxdqURWQlXOioP8EQjmSLHbfvNGD2 MSkmq3UBw/tlAktx11ZlJWU9bmEBBy1z689pDOnfB4zBTk7DY8eiQ7J+ X-Gm-Gg: AYBFou0R/Bnur8hfsovXcsTNO0TlrY2Mga4iT2A8ZXmu8WsrdtWAnbAs+rznlt/BfPx EvC3Fm5LLC5Nr3b0r6Y6cWm3KmhdfSd7KF4A1rb56iSpFgRDyUo8xLrWQ5CZ+fbLU+2zVP90sLW HK+pQzB/4TimWEJFdrsYouC1FF+/jgZe8ZSMgVlnV5uetpUy5WTbGu/tboq8Fx9e9De0vsbaD+X vh9t/V63rp/5HnRL7+WE9/7pPHjUCbTQidrTU/uzeCSfEx7JpPBZA/7o0KTdFUDlQN5ETWh8dg9 3iJxsT/OSeNlAhQrqw9GVMnOQ3c0JkExL3xio7gjlbfb2u1gKYogxJ3KJpHnmLnXDCPp7msuz+h wKeVuTnjhd5vV8vpnFuVzCuEs5s1bPInWNlvCld6uuN+8n1AuN/RGUYB7rB9+JnY3oiURsco+lj V6gijVC0iYUSGDRN33PSKdaCsCkacXText++rOjfQzjC5Medqf9W7PrPO7/SHtr6IliSiJemMzA y+SeyRlBLcw481eVWx7pH12gF1R X-Received: by 2002:a05:6000:491a:b0:482:ea08:8c97 with SMTP id ffacd0b85a97d-48488e0392dmr13325516f8f.2.1788376047145; Wed, 02 Sep 2026 12:07:27 -0700 (PDT) Received: from [192.168.1.9] ([148.252.128.8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448e80388sm9518927f8f.14.2026.09.02.12.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 12:07:26 -0700 (PDT) From: Dale Whinham Date: Wed, 02 Sep 2026 20:07:16 +0100 Subject: [PATCH v3] arm64: dts: qcom: x1-denali: Add volume up/down GPIO keys Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260902-surface-pro-11-volume-buttons-v3-1-9d41987bcd75@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/43OQQ6CMBAF0KuQrh3TloLgynsYF7QMUAOUtNBoC He3xYXudPkzP+/PShxajY6ck5VY9NppM4aQHhKiumpsEXQdMuGU57TgJbjFNpVCmKwBxsCbfhk Q5DLPZnTQCCko8kyhkiQYk8VGP3b/entnt8g7qjmisdFpNxv73B/wLPb+3fIMGIRzVpSpSKu8u LRDpfujMgOJW55/tJLyXxoPGquDpU4yE4J+a9u2vQBGFsCFKgEAAA== X-Change-ID: 20260829-surface-pro-11-volume-buttons-f4b40e25cecb To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?J=C3=A9r=C3=B4me_de_Bretagne?= , Konrad Dybcio , Abel Vesa , Dale Whinham X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788376045; l=3391; i=daleyo@gmail.com; s=20251214; h=from:subject:message-id; bh=/GqE7tbYa2dWg0FxwYbCrxOWd45I2GVxpnOL6juTks4=; b=/L/FiUEdcMYd8AUfzRtemoMmvDtSWlNwWBtH0gnIoq5ej1LFSXauNVyUtRw4Hlr8kOMBuzEzI ELrUwGmIu+GBG2kBrkHsac8kpBUlrrh7+fjgsCYCYQX0r+Eosyuz6PI X-Developer-Key: i=daleyo@gmail.com; a=ed25519; pk=M4mvgx1TB2TniKaedTDsO3PbLKgFosJuegXRXPbn2Ds= Configure gpio6 and gpio8 as volume up and volume down respectively, to enable the volume rocker located at the top of the screen. Reviewed-by: Konrad Dybcio Reviewed-by: Abel Vesa Signed-off-by: Dale Whinham --- Note: the DTS coding style says properties within a group shall use natural sort order by name, which for the new pin state nodes would give bias-pull-up, function, input-enable, pins, power-source. I've instead led with pins and function, matching every other pin configuration group in the x1* device trees. Happy to switch to the strict natural sort if that's preferred. --- Changes in v3: - Sort the child nodes of gpio-keys alphabetically by name, and re-order the pinctrl-0 entries to match (Konrad, DTS style guide). - Re-order the properties within the new pin state nodes to lead with pins and function, matching the other x1* pin state nodes. - Link to v2: https://patch.msgid.link/20260902-surface-pro-11-volume-buttons-v2-1-1d893c7b5440@gmail.com Changes in v2: - Sort the new pin configuration nodes by controller and GPIO number (Konrad) - Link to v1: https://patch.msgid.link/20260829-surface-pro-11-volume-buttons-v1-1-ace589343a68@gmail.com To: Bjorn Andersson To: Konrad Dybcio To: Rob Herring To: Krzysztof Kozlowski To: Conor Dooley Cc: linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi | 36 ++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi b/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi index 7559557610ed..c14a1b9b1130 100644 --- a/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi +++ b/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi @@ -20,9 +20,27 @@ aliases { gpio-keys { compatible = "gpio-keys"; - pinctrl-0 = <&hall_int_n_default>; + pinctrl-0 = <&vol_down_n>, <&vol_up_n>, <&hall_int_n_default>; pinctrl-names = "default"; + key-vol-down { + debounce-interval = <15>; + gpios = <&pm8550_gpios 8 GPIO_ACTIVE_LOW>; + label = "Volume Down"; + linux,can-disable; + linux,code = ; + wakeup-source; + }; + + key-vol-up { + debounce-interval = <15>; + gpios = <&pm8550_gpios 6 GPIO_ACTIVE_LOW>; + label = "Volume Up"; + linux,can-disable; + linux,code = ; + wakeup-source; + }; + switch-lid { gpios = <&tlmm 2 GPIO_ACTIVE_LOW>; linux,input-type = ; @@ -984,6 +1002,22 @@ &pcie6a_port0 { }; &pm8550_gpios { + vol_up_n: vol-up-n-state { + pins = "gpio6"; + function = "normal"; + bias-pull-up; + input-enable; + power-source = <1>; /* 1.8V */ + }; + + vol_down_n: vol-down-n-state { + pins = "gpio8"; + function = "normal"; + bias-pull-up; + input-enable; + power-source = <1>; /* 1.8V */ + }; + rtmr0_default: rtmr0-reset-n-active-state { pins = "gpio10"; function = "normal"; --- base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f change-id: 20260829-surface-pro-11-volume-buttons-f4b40e25cecb Best regards, -- Dale Whinham