From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add onsemi FUSB15201 Type-C and PD controller
Date: Wed, 02 Sep 2026 05:07:23 +0000 [thread overview]
Message-ID: <20260902050724.15E071F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902045938.184221-2-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Invalid application of JSON Schema 'maximum' keyword to the 'reg' array property.
--
commit 5b798d6ff22fa60fafae940009972a32c9ecd0c7
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
dt-bindings: usb: Add onsemi FUSB15201 Type-C and PD controller
This commit introduces a device tree binding for the onsemi FUSB15201, an
autonomous dual-port USB Type-C and Power Delivery controller. It defines
the required properties, interrupts, and connector child nodes to describe
the ports in a device tree.
> diff --git a/Documentation/devicetree/bindings/usb/onnn,fusb15201.yaml b/Documentation/devicetree/bindings/usb/onnn,fusb15201.yaml
> new file mode 100644
> index 0000000000000..09f2e964d3ef3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/onnn,fusb15201.yaml
> @@ -0,0 +1,152 @@
[ ... ]
> +patternProperties:
> + '^connector@[01]$':
> + type: object
> + $ref: /schemas/connector/usb-connector.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + compatible:
> + const: usb-c-connector
> +
> + reg:
> + maximum: 1
[Severity: Low]
Does this introduce a regression by applying the JSON Schema maximum keyword
directly to the reg property?
The reg property is an array in device tree schemas, so applying a numeric
keyword like maximum to it is syntactically invalid and silently ignored by
validation tools.
Because the node name regex ^connector@[01]$ combined with automatic unit
address validation already restricts the value to 0 or 1, this doesn't allow
invalid hardware descriptions to pass.
Should this constraint be updated to use an items list constraint, or removed
entirely since the unit address validation already enforces the limits?
> + description:
> + 0 for port A, 1 for port B.
> +
> + required:
> + - reg
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902045938.184221-1-shengchao.guo@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-02 5:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 4:59 [PATCH 0/2] usb: typec: Add onsemi FUSB15201 support Shawn Guo
2026-09-02 4:59 ` [PATCH 1/2] dt-bindings: usb: Add onsemi FUSB15201 Type-C and PD controller Shawn Guo
2026-09-02 5:07 ` sashiko-bot [this message]
2026-09-02 4:59 ` [PATCH 2/2] usb: typec: Add onsemi FUSB15201 driver Shawn Guo
2026-09-02 5:12 ` sashiko-bot
2026-09-02 13:30 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902050724.15E071F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox