From: sashiko-bot@kernel.org
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU
Date: Wed, 02 Sep 2026 08:18:50 +0000 [thread overview]
Message-ID: <20260902081850.C15861F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902-dts-qcom-eliza-evk-enable-gpu-v2-1-51b452a460a2@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The overridden DT nodes are not sorted alphabetically by label.
--
commit 69d2b599210486d1fb104df39a0da4a840c7aa02
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU
Enable the Adreno 722 GPU on the Eliza CQS SoM board and provide the zap
shader firmware path.
> diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> index 5ef6c51618bf9..918f5289ca45f 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> @@ -374,6 +374,14 @@ &pm7550ba_eusb2_repeater {
> vdd3-supply = <&vreg_l17b>;
> };
>
> +&gpu {
[Severity: Low]
This isn't a bug, but should the overridden DT nodes at the root level be
sorted alphabetically by their label to maintain consistency?
Since 'g' comes before 'p', the &gpu and &gpu_zap_shader nodes inserted here
in arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi should probably be placed
before &pm7550ba_eusb2_repeater.
> + status = "okay";
> +};
> +
> +&gpu_zap_shader {
> + firmware-name = "qcom/eliza/gen71700_zap.mbn";
> +};
> +
> &remoteproc_adsp {
> firmware-name = "qcom/eliza/adsp.mbn",
> "qcom/eliza/adsp_dtb.mbn";
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-dts-qcom-eliza-evk-enable-gpu-v2-1-51b452a460a2@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-02 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 8:13 [PATCH v2] arm64: dts: qcom: eliza-cqs-som: Enable Adreno A722 GPU Abel Vesa
2026-09-02 8:18 ` sashiko-bot [this message]
2026-09-02 8:25 ` Abel Vesa
2026-09-11 2:25 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902081850.C15861F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox