From: Dinh Nguyen <dinguyen@kernel.org>
To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: dinguyen@kernel.org, devicetree@vger.kernel.org, rounakdas2025@gmail.com
Subject: [RFC PATCH 1/2] dt-bindings: edac: altera: agilex5: document new edac support
Date: Wed, 2 Sep 2026 04:25:50 -0500 [thread overview]
Message-ID: <20260902092551.488203-2-dinguyen@kernel.org> (raw)
In-Reply-To: <20260902092551.488203-1-dinguyen@kernel.org>
The Agilex5 EDAC module supports ECC on a few additional peripherals. Along
with support for ocram, ethernet and USB, the Agilex5 EDAC adds support for
SDM QSPI, CRAM SEU and IO96B.
The Agilex5 EDAC also exposes up to 7 named interrupts on the manager
node. global_sbe and global_dbe are aggregate single/double-bit error
interrupts that fan-out through the manager's IRQ domain to the child
peripheral ECCs. The remaining named interrupts are routed directly from
dedicated controllers (IO96B memory controllers and Secure Device Manager)
to the GIC.
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
v2: add if/then to enforce maxItem of 2 interrupts for older platforms,
and 7 for Agilex5
add if/then to enforce interrupt-names as required property for
Agilex5
enum altr,socfpga-s10-ecc-manager and altr,socfpga-agilex5-ecc-manager
---
.../edac/altr,socfpga-ecc-manager.yaml | 85 +++++++++++++------
1 file changed, 61 insertions(+), 24 deletions(-)
diff --git a/Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml b/Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml
index 136e8fccd429a..16940b49471cd 100644
--- a/Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml
+++ b/Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml
@@ -20,7 +20,9 @@ properties:
compatible:
oneOf:
- items:
- - const: altr,socfpga-s10-ecc-manager
+ - enum:
+ - altr,socfpga-s10-ecc-manager
+ - altr,socfpga-agilex5-ecc-manager
- const: altr,socfpga-a10-ecc-manager
- const: altr,socfpga-a10-ecc-manager
- const: altr,socfpga-ecc-manager
@@ -33,7 +35,25 @@ properties:
interrupts:
minItems: 1
- maxItems: 2
+ items:
+ - description: Global single-bit error
+ - description: Global double-bit error
+ - description: IO96B0 DRAM controller error
+ - description: IO96B1 DRAM controller error
+ - description: SDM QSPI single-bit error
+ - description: SDM QSPI double-bit error
+ - description: SDM single-event
+
+ interrupt-names:
+ minItems: 1
+ items:
+ - const: global_sbe
+ - const: global_dbe
+ - const: io96b0
+ - const: io96b1
+ - const: sdm_qspi_sbe
+ - const: sdm_qspi_dbe
+ - const: sdm_seu
interrupt-controller: true
@@ -235,28 +255,45 @@ patternProperties:
- interrupts
- altr,ecc-parent
-if:
- properties:
- compatible:
- contains:
- const: altr,socfpga-ecc-manager
-then:
- required:
- - compatible
- - "#address-cells"
- - "#size-cells"
- - ranges
-
-else:
- required:
- - compatible
- - "#address-cells"
- - "#size-cells"
- - interrupts
- - interrupt-controller
- - "#interrupt-cells"
- - ranges
- - altr,sysmgr-syscon
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: altr,socfpga-ecc-manager
+ then:
+ required:
+ - compatible
+ - "#address-cells"
+ - "#size-cells"
+ - ranges
+
+ else:
+ required:
+ - compatible
+ - "#address-cells"
+ - "#size-cells"
+ - interrupts
+ - interrupt-controller
+ - "#interrupt-cells"
+ - ranges
+ - altr,sysmgr-syscon
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: altr,socfpga-agilex5-ecc-manager
+ then:
+ properties:
+ interrupts:
+ maxItems: 7
+ required:
+ - interrupt-names
+ else:
+ properties:
+ interrupts:
+ maxItems: 2
additionalProperties: false
--
2.42.0.411.g813d9a9188
next prev parent reply other threads:[~2026-09-02 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 9:25 [RFC 0/2] arm64: dts: socfpga: clarify MMIO vs non-MMIO nodes Dinh Nguyen
2026-09-02 9:25 ` Dinh Nguyen [this message]
2026-09-02 9:25 ` [RFC PATCH 2/2] arm64: dts: socfpga: agilex5: add support for the ECC manager Dinh Nguyen
2026-09-02 9:38 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902092551.488203-2-dinguyen@kernel.org \
--to=dinguyen@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=rounakdas2025@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox