Re: [PATCH v11 3/3] iio: dac: Add AD5529R DAC driver support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Selecting REGMAP_SPI without inheriting its dependency on SPI causes unmet direct dependency warnings.
--

commit 4f95e4db1e621b9be7d174948b61e89bec2d8d32
Author: Janani Sunil <janani.sunil@analog.com>

iio: dac: Add AD5529R DAC driver support

This commit adds support for the Analog Devices AD5529R 16-channel, 12/16 bit DAC.
The device communicates over SPI and supports per-channel output range
configuration and an optional external reference.

> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
[ ... ]
> +config AD5529R
> +	tristate "Analog Devices AD5529R High Voltage DAC driver"
> +	depends on SPI_MASTER
> +	select REGMAP_SPI

[Severity: Low]
Will this cause Kconfig unmet direct dependency warnings and subsequent
linker errors if a user configures SPI=m?

When SPI=m, the boolean SPI_MASTER evaluates to y. This allows AD5529R to
be configured as y, which in turn forces REGMAP_SPI to y.

Since REGMAP_SPI depends on the SPI tristate symbol, selecting it without
inheriting its dependency on SPI can lead to undefined references to SPI
core functions during the vmlinux linking stage.

> +	help
> +	  Say yes here to build support for Analog Devices AD5529R 16-Channel,
> +	  12-Bit/16-Bit, 40V High Voltage Precision Digital to Analog Converter.
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-ad5529r-driver-v11-0-301c491a0719@analog.com?part=3