Re: [PATCH 1/2] arm: dts: sunplus: add peripheral device nodes to sp7021.dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The Ethernet switch node ('l2sw') specifies multiple clocks and a 'clock-names' property, which violate the sunplus,sp7021-emac binding schema.
- [Medium] The PWM node defines a 'resets' property which is undocumented and forbidden by the sunplus,sp7021-pwm.yaml binding schema.
- [Medium] The Ethernet controller node ('l2sw') unconditionally omits required properties in the .dtsi.
--

commit 7acbbeff4684bdd9972c059005ca817139e446fa
Author: Andrew Gaylard <ag@ffroot.co.za>

arm: dts: sunplus: add peripheral device nodes to sp7021.dtsi

This patch adds device tree nodes for the PWM controller, watchdog, eMMC
controller, and Ethernet switch to the SP7021 device tree include file.

> diff --git a/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi b/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi
> index ae9bbe0320b8d..9bb349a5542a4 100644
> --- a/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi
> +++ b/arch/arm/boot/dts/sunplus/sunplus-sp7021.dtsi
> @@ -291,6 +291,54 @@ uart4: serial@8780 {
[ ... ]
> +		pwm: pwm@7a00 {
> +			#pwm-cells = <2>;
> +			compatible = "sunplus,sp7021-pwm";
> +			reg = <0x7a00 0x80>;
> +			clocks = <&clkc CLK_DISP_PWM>;
> +			resets = <&rstc RST_DISP_PWM>;

[Severity: Medium]
Does the sunplus,sp7021-pwm.yaml binding schema support the resets property?

The schema appears to lack a definition for resets and specifies
unevaluatedProperties: false, which causes a schema validation error when
compiling the device tree with dtbs_check.

> +			status = "disabled";
> +		};
[ ... ]
> +		l2sw: ethernet@108000 {
> +			compatible = "sunplus,sp7021-emac";
> +			reg = <0x108000 0x400>;

[Severity: Medium]
Will this node cause dtbs_check validation to fail because it omits several
required properties?

The sunplus,sp7021-emac.yaml schema lists pinctrl-0, pinctrl-names,
ethernet-ports, and mdio as required. Including this include file in a board
device tree without overriding the node to supply these properties triggers
validation errors, as setting status = "disabled" does not bypass schema
requirements.

> +			interrupts = <66 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clkc CLK_L2SW>, <&clkc PLL_E_25>,
> +				 <&clkc PLL_E_2P5>, <&clkc PLL_E_112P5>;
> +			clock-names = "l2sw", "plle_25", "plle_2p5", "plle_112p5";

[Severity: Medium]
Do these properties conflict with the constraints defined in the EMAC YAML
schema?

The sunplus,sp7021-emac.yaml schema explicitly restricts clocks to a
maximum of one item and enforces additionalProperties: false, making the
clock-names property invalid.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902104545.67794-1-ag@ffroot.co.za?part=1