Re: [PATCH v45 6/7] arm64: dts: imx8ulp: add secure enclave node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message erroneously claims to add a label for 'sram@2201f000', but the patch actually adds the label to 'sram@22010000'.
--

commit f6aa8515a434b2969a55227494277b2542fee770
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. It also aims to add a label to the SRAM node referenced
by the enclave.

> Add the EdgeLock Enclave (ELE) secure-enclave node to the i.MX8ULP SoC
> dtsi, together with a label for sram@2201f000 that the node references.

[Severity: Medium]
Is the commit message description accurate regarding the SRAM address?

The text mentions adding a label for sram@2201f000, but the diff below
shows the label is actually applied to sram@22010000 instead.

Could this mismatch between the commit message and the device tree code
cause confusion about which SRAM section is allocated to the secure enclave?

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
[ ... ]
> @@ -154,7 +154,7 @@ sosc: clock-sosc {
>  		#clock-cells = <0>;
>  	};
>  
> -	sram@22010000 {
> +	sram0: sram@22010000 {
>  		compatible = "mmio-sram";
>  		reg = <0x0 0x22010000 0x0 0x10000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-imx-se-if-v45-0-6e400879d8ec@nxp.com?part=6